modules: A collection of small fixes for loadable modules #9333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cture Add the const modifier to system_service structures containing pointers to shared functions to protect them from accidental modification. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
The Logger class ia a log wrapper intended for use by IADK loadable modules. Remove it because it is not needed in the sof. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Correct the include guard name which was not changed when changing the file name. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Add the label "(optional)" in the function documentation for functions whose implementation by a module is optional. The module adapter checks whether the function is provided by the module before calling it. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
softwarecki
requested review from
lgirdwood,
tobonex,
abonislawski,
kv2019i,
marcinszkudlinski,
jxstelter,
tmleman,
serhiy-katsyuba-intel and
gbernatxintel
softwarecki
requested review from
plbossart,
mmaka1,
lbetlej and
dbaluta
as code owners
lgirdwood
approved these changes
Jul 26, 2024
tobonex
approved these changes
Jul 26, 2024
tmleman
approved these changes
Jul 26, 2024
gbernatxintel
approved these changes
Jul 26, 2024
|
This seems odd https://sof-ci.01.org/sofpr/PR9333/build6728/devicetest/index.html?model=LNLM_RVP_NOCODEC&testcase=check-pause-resume-capture-100 , but given the changes affect the loadable module part only, I can't see how this can be connected. Proceeding with merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the const modifier to system_service structures containing pointers to shared functions to protect them from accidental modification.
The Logger class ia a log wrapper intended for use by IADK loadable modules. Remove it because it is not needed in the sof.
Correct the include guard name which was not changed when changing the file name.
Add the label "(optional)" in the function documentation for functions whose implementation by a module is optional. The module adapter checks whether the function is provided by the module before calling it.