-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dropdowns to all chapter for key takeaways
and environment setup
#333
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome!
A few requests:
- Could we spin your observations concerning missing and too general environments into a follow up issue, please?
- I wonder whether we should have the boxes after the chapter title. What do you think?
@@ -0,0 +1,28 @@ | |||
1. **Save the yml content**: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There might need to be another step before that which explains how to install Conda. Could you add one sentence on that, please?
|
Both options are great! But in both cases, I would keep it as a dropdown. It just makes the chapters appear less long. It is however a bit weird to me that the environment setup is at the bottom for the scrollable option. I know that we have the session-info at the bottom but that seems to be more common than a "how to setup the environment guide". Should we ask more people for feedback? We can ask in the big sc-best-practices channel. We can also make a decision among the three of us. |
key takeaways
and 'environment setup'
key takeaways
and 'environment setup'key takeaways
and environment setup
key takeaways
and environment setup
key takeaways
and environment setup
Finally! 🎊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
I added two types of dropdown boxes to all the chapters:
1. Key takeaways:
2. Environment setup:
default_text_env_setup.md
for the "steps"-tab and the corresponding yml file for the "yml"-tab.Please have a look when you have time :)