Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Katello bats tests to better repo (fix Katello nightly BATS failures) #1806

Merged

Conversation

ianballou
Copy link
Contributor

rpm-packages-updateinfo contains an important erratum (the SEA one) that points to the wrong RPMs. rpm-no-comps correctly points to walrus-5.21.

Also added some repo cleanup since the Pulp fixtures reuse RPMs, which causes clashes between the modular and non-modular versions of the RPMs.

Should fixes the Katello nightly pipeline.

Tested against nightly.

bats/fb-katello-content.bats Fixed Show fixed Hide fixed
bats/fb-katello-content.bats Fixed Show fixed Hide fixed
@ianballou ianballou changed the title Switch Katello bats tests to better repo Switch Katello bats tests to better repo (fix Katello nightly BATS failures) Apr 2, 2024
@ehelms
Copy link
Member

ehelms commented Apr 2, 2024

@ianballou looks good, can you address the shell check comments?

@ianballou
Copy link
Contributor Author

Doing a final full test and then I'll push up the last changes

@ianballou ianballou force-pushed the cleanup-repos-to-fix-katello-bats branch from d3658f6 to e53b17f Compare April 2, 2024 15:26
@ianballou
Copy link
Contributor Author

@ehelms this is good to go now, finished up my testing.

@@ -0,0 +1 @@
Zoo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might've snuck in, lemme double check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, it's deleted.

@ianballou ianballou force-pushed the cleanup-repos-to-fix-katello-bats branch from e53b17f to 334e2bc Compare April 2, 2024 17:26
@ehelms ehelms merged commit b5a4acd into theforeman:master Apr 2, 2024
8 checks passed
@ianballou ianballou deleted the cleanup-repos-to-fix-katello-bats branch April 2, 2024 17:32
@ehelms
Copy link
Member

ehelms commented Apr 5, 2024

Yea - see theforeman/foreman-packaging#10669

@evgeni
Copy link
Member

evgeni commented Apr 5, 2024

Oooh, that's related?!

@ehelms
Copy link
Member

ehelms commented Apr 5, 2024

Oooh, that's related?!

Yep, check the output:


[2024-04-04T23:50:20.340Z]     # $ hammer repository delete --organization="${ORGANIZATION}" --product="${PRODUCT}" --name="${YUM_REPOSITORY_2}" --remove-from-content-view-versions=true

[2024-04-04T23:50:20.340Z]     # Repository deleted.

[2024-04-04T23:50:20.340Z]     # $ hammer repository delete --organization="${ORGANIZATION}" --product="${PRODUCT}" --name="${YUM_REPOSITORY_3}" --remove-from-content-view-versions=true

[2024-04-04T23:50:20.340Z]     # Repository deleted.

[2024-04-04T23:50:20.340Z]     # $ echo "::ForemanTasks.sync_task(::Actions::Katello::OrphanCleanup::RemoveOrphans, SmartProxy.pulp_primary)"

[2024-04-04T23:50:20.340Z]     # $ foreman-rake console

[2024-04-04T23:50:20.340Z]     # rake aborted!

[2024-04-04T23:50:20.340Z]     # LoadError: cannot load such file -- irb

@evgeni
Copy link
Member

evgeni commented Apr 5, 2024

What a way to find a bug ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants