Cleaning up unused code paths #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
reviewed
Feb 21, 2024
Comment on lines
96
to
97
| sql += 'DELETE FROM foreman_tasks_links as ftl ' \ | ||
| 'where ftl.task_id NOT IN (SELECT id FROM foreman_tasks_tasks);' |
There was a problem hiding this comment.
should we just roll this into the sql defined in L87-94? no need to += IMHO.
evgeni
reviewed
Feb 21, 2024
| @@ -12,28 +12,12 @@ def run | |||
|
|
|||
| def installer_cmd | |||
| installer = "yes | #{feature(:installer).installer_command} " | |||
There was a problem hiding this comment.
someone needs to remind me, why this yes | is required, but out of scope for this PR probably.
evgeni
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.