Skip to content

Commit

Permalink
Retain specific int details in docblocks
Browse files Browse the repository at this point in the history
We're already using PHPStan's more-specific-types _some_ of the time - let's do it consistently?

See also: thecodingmachine/phpstan-safe-rule#52
  • Loading branch information
shish committed Feb 19, 2025
1 parent a775bd3 commit efc63c4
Show file tree
Hide file tree
Showing 85 changed files with 269 additions and 262 deletions.
2 changes: 2 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ Intentional changes:
* If the function returned `true` on success and `false` on error, and we have
removed the `false`, then the signature gets changed from `bool` to `void` to
stop people from accidentally writing `if(function()) {...}`
* PHPDoc comments use the more specific type hints from PHPStan, eg `array<string>` rather than
`array`, or `0|1` rather than `int`

Necessary changes / side effects:
* Functions which have optional parameters without defaults (eg `cubrid_bind()` has
Expand Down
4 changes: 2 additions & 2 deletions generated/8.1/dir.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generated/8.1/errorfunc.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 13 additions & 13 deletions generated/8.1/filesystem.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions generated/8.1/ftp.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generated/8.1/iconv.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions generated/8.1/image.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generated/8.1/json.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions generated/8.1/mbstring.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generated/8.1/network.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generated/8.1/oci8.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions generated/8.1/openssl.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions generated/8.1/pcre.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions generated/8.1/posix.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generated/8.1/stream.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions generated/8.1/zlib.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit efc63c4

Please sign in to comment.