fix: Missing rain sounds #689
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug terrarium-earth#628 (no rain particles/sound generated in the overworld), while retaining custom effects when player is on Venus. (To assist Create: Astral modpack)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug #628 (no rain particles) - restoring rain sounds in the overworld, while retaining custom effects when player is on Venus.
Slightly changed test for detecting if player is on Venus (skips new code if player is elsewhere, to allow rain particles in other world dimensions to render again, resulting in rain sounds being played as normal)
(My first ever Github contribution! Apologies, I know the 1.18.2 branch is old, but wanted to assist Create: Astral modpack users)