Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#18515: Moved conv and pool tests to new folders, changed codeowners #18701

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

#18515: Moved conv and pool tests to new folders, changed codeowners #18701

wants to merge 1 commit into from

Conversation

skrsticTT
Copy link
Contributor

@skrsticTT skrsticTT commented Mar 6, 2025 •
edited
Loading

Ticket

#18515

Changes

  1. Made conv and pool folders inside tests/ttnn/unit_tests/operations/
  2. Moved corresponding tests to each folder
  3. Renamed folder names for pool/conv in tests/ttnn/nightly/unit_tests/operations/
  4. Changed CODEOWNERS file

Moved following tests in UT conv folder:

  • Conv2d
  • Conv1d
  • Conv2d transposed
  • Prepare conv weights
  • Conv3d

Moved following tests in UT pool folder:

@skrsticTT skrsticTT self-assigned this Mar 6, 2025
pavlejosipovic
pavlejosipovic reviewed Mar 6, 2025
View reviewed changes
Copy link
Contributor

@pavlejosipovic pavlejosipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls do this for nightly tests as well.
tests/ttnn/nightly/unit_tests/operations/conv2d/...
tests/ttnn/nightly/unit_tests/operations/max_pool2d/...

pavlejosipovic
pavlejosipovic reviewed Mar 6, 2025
View reviewed changes
Copy link
Contributor

@pavlejosipovic pavlejosipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post a passing post commit pipeline and nightly pipeline

@skrsticTT skrsticTT force-pushed the skrstic/cleanup-ut-review-list-conv branch 2 times, most recently from def758c to fb1ac94 Compare March 7, 2025 10:31
@skrsticTT skrsticTT force-pushed the skrstic/cleanup-ut-review-list-conv branch from fb1ac94 to 6b6fd2d Compare March 7, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavlejosipovic pavlejosipovic pavlejosipovic approved these changes

@tt-rkim tt-rkim tt-rkim approved these changes

@bbradelTT bbradelTT bbradelTT approved these changes

@ayerofieiev-tt ayerofieiev-tt Awaiting requested review from ayerofieiev-tt ayerofieiev-tt is a code owner

@dmakoviichuk-tt dmakoviichuk-tt Awaiting requested review from dmakoviichuk-tt dmakoviichuk-tt is a code owner

@rfurko-tt rfurko-tt Awaiting requested review from rfurko-tt rfurko-tt is a code owner

@cfjchu cfjchu Awaiting requested review from cfjchu cfjchu is a code owner

@TT-BrianLiu TT-BrianLiu Awaiting requested review from TT-BrianLiu TT-BrianLiu is a code owner

@razorback3 razorback3 Awaiting requested review from razorback3 razorback3 is a code owner

@dongjin-na dongjin-na Awaiting requested review from dongjin-na dongjin-na is a code owner

@omilyutin-tt omilyutin-tt Awaiting requested review from omilyutin-tt omilyutin-tt is a code owner

Assignees

@skrsticTT skrsticTT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skrsticTT @pavlejosipovic @tt-rkim @bbradelTT