Skip to content

Commit

Permalink
#17536: change fatals to asserts for some matmul mem config checks
Browse files Browse the repository at this point in the history
  • Loading branch information
bbradelTT committed Mar 6, 2025
1 parent 4b0ee35 commit 3eefcc1
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions ttnn/cpp/ttnn/operations/matmul/device/matmul_op.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1453,12 +1453,13 @@ void Matmul::validate(
output_tensor_spec.memory_config(),
this->output_mem_config);
} else {
TT_FATAL(
// TODO: try to change these to fatals and fix test_llama_model.py in APC
TT_ASSERT(
output_tensor_spec.memory_config().memory_layout == this->output_mem_config.memory_layout,
"Mismatch between computed {} and provided {} mem config memory layout",
output_tensor_spec.memory_config().memory_layout,
this->output_mem_config.memory_layout);
TT_FATAL(
TT_ASSERT(
output_tensor_spec.memory_config().buffer_type == this->output_mem_config.buffer_type,
"Mismatch between computed {} and provided {} mem config buffer type",
output_tensor_spec.memory_config().buffer_type,
Expand Down

0 comments on commit 3eefcc1

Please sign in to comment.