TBS-2755: Improve ETCD timeout handling #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add graceful timeout handling in Connection module
- Return {:error, :timeout} instead of crashing
- Update documentation with timeout behavior
- Set default timeout to 5 seconds
- Add error handling sections in docs
Pull Request Test Coverage Report for Build 696463a1ff0837edd9e1d41597b8a82634cda048-PR-9Details
💛 - Coveralls |
ammbot
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves how ETCD timeouts are handled in the library. Instead of crashing when an operation times out, it now returns a proper error tuple.
Changes
{:error, :timeout}instead of crashingTesting
The changes are backward compatible and only affect error handling behavior. No existing functionality is modified.
Related Issues
Closes TBS-2755