Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo #7

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Repo #7

wants to merge 2 commits into from

Conversation

szajbus
Copy link
Contributor

@szajbus szajbus commented Jul 19, 2024

This PR adds some useful features, building on top of library's basic functions.

  • Repository - a middleware between application logic and bare Etcd API, watches Etcd for changes, caches data locally, makes all search and get operations local, but also provides API for writing data
  • Lease - process that helps to establish and maintain leases

It's still a draft, but it is fully functional already. It just needs a proper documentation in README and module docs.

Copy link

Pull Request Test Coverage Report for Build 24fed86179c54f7b0f69454220d1c26ba99fee21-PR-7

Details

  • 67 of 125 (53.6%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.6%) to 64.975%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/etcd_ex/lease/mock.ex 0 4 0.0%
lib/etcd_ex/repo.ex 18 23 78.26%
lib/etcd_ex/repo/cache.ex 49 71 69.01%
lib/etcd_ex/lease.ex 0 27 0.0%
Totals Coverage Status
Change from base Build b842d383bd1f96c25789fde81a4ac7df51326d58: -2.6%
Covered Lines: 384
Relevant Lines: 591

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant