Manually specialize parts of CRC32 implementation to speed them up debug mode #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for the long delay, things got pretty busy and then I moved on to other not png-related parts of my projects. I've now switched I'm pretty sure I've addressed your concerns with my latest commit. If this PR goes against the philosophy of this project (e.g. if debug mode performance is a non-goal) I don't mind if you decide to close this PR instead of merging. I'm not too attached either way. |
|
looks good, thanks! sorry swift-png didn’t work out for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are related to my debug mode optimisation PR on for
swift-pngand have to be merged before that PR can be merged.These optimisations corresponded to about a 20% improvement in debug mode PNG decoding at the time that I implemented them.
Please tag a new version (probably just a patch version?) once this is merged to that I can update my
swift-pngPR to point to it.