Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dest: return proper data in graphql errors #3676

Merged
merged 4 commits into from
Feb 12, 2024
Merged

Conversation

mastercactapus
Copy link
Member

Which issue(s) this PR fixes:
This PR adds a normalized output to destination validation errors (currently only called from contact method input dest field).

  • extensions.code will be one of: INVALID_DESTINATION_TYPE or INVALID_DESTINATION_FIELD_VALUE
  • The .path property of errors will reflect the actual input field (and fieldID) that failed validation

Out of Scope:
Since no code currently uses this, tests will be added with the user contact method dialog PR(s).

Describe any introduced user-facing changes:
N/A

Describe any introduced API changes:

  • Destination validation errors are now well-defined.

Additional Info:
Existing field errors are unaffected.

@mastercactapus mastercactapus merged commit 230df8d into master Feb 12, 2024
7 checks passed
@mastercactapus mastercactapus deleted the dest-error-api branch February 12, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants