-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
users: use generic destinations for user CM create dialog component #3664
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed a couple issues when functionally testing:
- the docs page in storybook seems broken, maybe we disable those for dialogs? unless there's a way to fix (related issue: Popup or Modal type component persist in screen if go to Docs or Guideline storybookjs/storybook#16949 -- looks like some things to try)
- errors aren't being fed -- i.e., enter
123
as a phone number and the validation error doesn't display - create dialog says status updates aren't supported for SMS which is incorrect
For the error stuff I think that's going to require a bit of extra thought; working on |
Sounds good. Thanks for pushing up the fixes to this branch! |
make check
to catch common errors. Fixed any that came up.Description:
This PR updates the UserContactMethod create and dialog components to use generic destinations when the experimental flag is set
make start EXPERIMENTAL=dest-types
.Which issue(s) this PR fixes:
part of #2639
Out of Scope:
N/A
Screenshots:





Describe any introduced user-facing changes:
N/A, behavior should be the same as today.
Describe any introduced API changes:
N/A
Additional Info:
N/A