Skip to content

Commit

Permalink
ci: upgrade node version (#3645)
Browse files Browse the repository at this point in the history
* update node

* regen yarn.lock

* update playwright version

* run full install command

* install before component tests

* default install cmd

* Revert "default install cmd"

This reverts commit e9acd53.

* update yarnrc version

* ensure single version of playwright

* add check for multiple playwright versions

---------

Co-authored-by: Nathaniel Caza <mastercactapus@gmail.com>
  • Loading branch information
KatieMSB and mastercactapus authored Feb 5, 2024
1 parent e2b14d1 commit b508ace
Show file tree
Hide file tree
Showing 6 changed files with 1,253 additions and 752 deletions.
2 changes: 1 addition & 1 deletion .yarnrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ defaultSemverRangePrefix: ''
packageExtensions:
jest-playwright-preset@*:
dependencies:
playwright: 1.40.1
playwright: 1.41.2
markdown-it@*:
dependencies:
punycode: 2.3.0
Expand Down
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,7 @@ test-unit: test

test-components: $(NODE_DEPS) bin/waitfor
yarn build-storybook --test --quiet 2>/dev/null
yarn playwright install chromium
yarn concurrently -k -s first -n "SB,TEST" -c "magenta,blue" \
"yarn http-server storybook-static -a 127.0.0.1 --port 6008 --silent" \
"./bin/waitfor tcp://localhost:6008 && yarn test-storybook --ci --url http://127.0.0.1:6008"
Expand Down
2 changes: 1 addition & 1 deletion devtools/ci/dockerfiles/build-env/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ RUN apt-get update && apt-get install -y \
dbus-x11 xvfb && \
rm -rf /var/lib/apt/lists/*

ADD https://nodejs.org/dist/v16.17.0/node-v16.17.0-linux-x64.tar.xz /tmp/node.tar.xz
ADD https://nodejs.org/dist/v20.11.0/node-v20.11.0-linux-x64.tar.xz /tmp/node.tar.xz
RUN tar -xvf /tmp/node.tar.xz -C /usr/local --strip-components=1 && rm /tmp/node.tar.xz

# yarn
Expand Down
8 changes: 8 additions & 0 deletions devtools/ci/tasks/scripts/codecheck.sh
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,14 @@ for file in $(find devtools -name '*.yml'); do
fi
done

# single version of playwright
NUM_VERSIONS=$(grep "^\"playwright@npm:" yarn.lock | wc -l)
if [ "$NUM_VERSIONS" -ne 1 ]; then
echo "Expected single version of playwright in yarn.lock, found $NUM_VERSIONS"
echo "Ensure package.json version of '@playwright/test' matches .yarnrc version of 'playwright'"
exit 1
fi

# taskfile contains quotes
if [ "'$PKG_JSON_VER'" != "$TASKFILE_VER" ]; then
echo "Cypress versions do not match:"
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"@mui/styles": "5.15.5",
"@mui/system": "5.15.6",
"@mui/x-data-grid": "6.18.7",
"@playwright/test": "1.40.1",
"@playwright/test": "1.41.2",
"@storybook/addon-essentials": "7.6.7",
"@storybook/addon-interactions": "7.6.7",
"@storybook/addon-links": "7.6.7",
Expand Down
Loading

0 comments on commit b508ace

Please sign in to comment.