router: delete vshard.router.bucket_discovery
#515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Astronomax
force-pushed
the
gh-503-deprecate-bucket-discovery
branch
from
56a4b04 to
69ecf83
Compare
Astronomax
force-pushed
the
gh-503-deprecate-bucket-discovery
branch
2 times, most recently
from
059ca38 to
ce29db1
Compare
The function `vshard.router.bucket_discovery` (marked "Router public API" in doc) does absolutely the same as `vshard.router.route` (marked "Router internal API" in doc). There is also another completely internal function `bucket_resolve` which returns the same as `bucket_discovery`. Actually `bucket_discovery` is not used internally, only `bucket_resolve` is used. Let's remove and not export `bucket_discovery`, leaving only `bucket_resolve` for internal needs. Closes tarantool#503 @TarantoolBot document Title: vshard: `vshard.router.bucket_discovery` is no longer available Root document: New page - https://www.tarantool.io/ru/doc/latest/reference/reference_rock/vshard/vshard_router/#router-api-bucket-discovery Previously, `vshard.router.bucket_discovery` was marked in the documentation as "Router internal API". Now it is not available at all.
Astronomax
force-pushed
the
gh-503-deprecate-bucket-discovery
branch
from
ce29db1 to
edfe4b6
Compare
Serpentian
approved these changes
Feb 26, 2025
Gerold103
approved these changes
Mar 3, 2025
|
@Astronomax please, cherry-pick to EE. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
vshard.router.bucket_discovery(marked "Router public API" in doc) does absolutely the same asvshard.router.route(marked "Router internal API" in doc). There is also another completely internal functionbucket_resolvewhich returns the same asbucket_discovery.Actually
bucket_discoveryis not used internally, onlybucket_resolveis used. Let's remove and not exportbucket_discovery, leaving onlybucket_resolvefor internal needs.Closes #503