refactored bridge envs and sorted them out #22
+161
−187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for t1-canary-bridge ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@princet1protocol Can you please fill out the PR Summary template in its entirety? |
Sorry! Filled it out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Refactored bridge envs to make sure the variable names match t1 deployment for efficiency
With this change, we can easily search t1 deployment variables and match them to the bridge variables without guessing which is which.
Also, have categorised them in similar fashion to t1 deployment variables for better readability
Checklist
I listed any breaking changes below:
I listed any env variable additions/changes/removals below:
NEXT_PUBLIC_L1_SCROLL_MESSENGER -> NEXT_PUBLIC_L1_T1_MESSENGER_PROXY_ADDR
NEXT_PUBLIC_L2_SCROLL_MESSENGER -> NEXT_PUBLIC_L2_T1_MESSENGER_PROXY_ADDR
NEXT_PUBLIC_L1_ERC20_WETH_ADDR -> NEXT_PUBLIC_L1_WETH_ADDR
NEXT_PUBLIC_L1_ERC20_USDT_ADDR -> NEXT_PUBLIC_L1_USDT_ADDR
NEXT_PUBLIC_L2_ERC20_WETH_ADDR -> NEXT_PUBLIC_L2_WETH_ADDR
NEXT_PUBLIC_L2_ERC20_USDT_ADDR -> NEXT_PUBLIC_L2_USDT_ADDR
NEXT_PUBLIC_L1_MESSAGE_QUEUE_WITH_GAS_PRICE_ORACLE -> NEXT_PUBLIC_L1_MESSAGE_QUEUE_PROXY_ADDR_WITH_GAS_PRICE_ORACLE
NEXT_PUBLIC_L1_GAS_PRICE_ORACLE -> NEXT_PUBLIC_L1_GAS_PRICE_ORACLE_ADDR
I checked whether I should update the docs in https://github.com/t1protocol/docs and if so, added PR link below:
I updated the notion task tracker's status and added link to this PR there