Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: 7683 demo #16

Open
wants to merge 10 commits into
base: canary
Choose a base branch
from
Open

Feature: 7683 demo #16

wants to merge 10 commits into from

Conversation

evchip
Copy link

@evchip evchip commented Feb 24, 2025

PR Summary

Contains 7683 demo data encoding and links to block explorers. Should be ripped out after ETH Denver. This document provides additional context.

Checklist

  • There are breaking changes
  • I've added/changed/removed ENV variable(s)
  • I checked whether I should update the docs and did so by updating /docs

@evchip evchip self-assigned this Feb 24, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 24, 2025 •
edited
Loading

✅ Deploy Preview for t1-canary-bridge ready!

Name Link
🔨 Latest commit 1536727
🔍 Latest deploy log https://app.netlify.com/sites/t1-canary-bridge/deploys/67c1bdb8d868fa0008d4ca9c
😎 Deploy Preview https://deploy-preview-16--t1-canary-bridge.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cankisagun
Copy link

screenshot

@evchip can we please add a text box on top for me to write a description of what's going on

Browser metadata 
Path:      /7683
Browser:   Chrome 131.0.0.0 on Mac OS 10.15.7
Viewport:  1676 x 852 @2x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

cankisagun
cankisagun previously approved these changes Feb 24, 2025
View reviewed changes
@evchip
Copy link
Author

evchip commented Feb 25, 2025

@evchip can we please add a text box on top for me to write a description of what's going on

Done @cankisagun
image

princet1protocol
princet1protocol reviewed Feb 27, 2025
View reviewed changes
src/app/7683/Send/OrderEncoder.tsx Outdated
amountIn: "1000000000000000000",
amountOut: "1000000000000000000",
senderNonce: Math.floor(Math.random() * 100000),
originDomain: "11155111", // Sepolia
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can use NEXT_PUBLIC_CHAIN_ID_L1

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thx

princet1protocol
princet1protocol reviewed Feb 27, 2025
View reviewed changes
src/app/7683/Send/OrderEncoder.tsx Outdated
amountOut: "1000000000000000000",
senderNonce: Math.floor(Math.random() * 100000),
originDomain: "11155111", // Sepolia
destinationDomain: "3151908", // t1 devnet
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here too NEXT_PUBLIC_CHAIN_ID_L2

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thx

princet1protocol
princet1protocol reviewed Feb 27, 2025
View reviewed changes
src/app/7683/Send/OrderEncoder.tsx Outdated
title="Open Intent"
action={
<a
href="https://sepolia.etherscan.io/address/0xcE90091836B14D1Ebc50d860E5e080Ea1465627b#writeProxyContract#F5"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets move 0xcE90091836B14D1Ebc50d860E5e080Ea1465627b to a constant defined on top, or if we are going serious, lets move it to .env

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thx

princet1protocol
princet1protocol reviewed Feb 27, 2025
View reviewed changes
src/app/7683/Send/OrderEncoder.tsx Outdated
title="Fill Intent"
action={
<a
href="https://explorer.devnet.t1protocol.com/address/0x16222661ff15e823b90f63024Eb891C7d30dc21b?tab=read_write_proxy&source_address=0x1D0dBA3F23Bf0b2653a23363245528635dDe0eaA#0x82e2c43f"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok i see now there are quite a few, i wont comment on them all to prevent repeated comments x)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thx

princet1protocol
princet1protocol reviewed Feb 27, 2025
View reviewed changes
src/app/7683/page.tsx Outdated
}, [])

useEffect(() => {
if (txType === "Deposit") {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see we have this, does it mean we have to make OrderEncoder dynamic in the future?
Understand its just a quick demo hacked together, but just putting it as a comment as a reminder

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was erroneously copied from the bridge component. I'll delete it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed, thx

@OrestTa
Copy link
Member

OrestTa commented Mar 1, 2025

@evchip can we please add a text box on top for me to write a description of what's going on

Done @cankisagun image

I think @cankisagun wanted this to be a non-input text field with some copy that he'd provide, to guide the user.

@diego-G diego-G self-requested a review March 3, 2025 16:18
@diego-G diego-G requested review from cankisagun and removed request for w-woloszyn and kss-t1 March 3, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrestTa OrestTa Awaiting requested review from OrestTa

@princet1protocol princet1protocol Awaiting requested review from princet1protocol

@diego-G diego-G Awaiting requested review from diego-G

@cankisagun cankisagun Awaiting requested review from cankisagun

At least 1 approving review is required to merge this pull request.

Assignees

@evchip evchip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@evchip @cankisagun @OrestTa @princet1protocol