Add statsd report for loud messages #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f00b4r0
force-pushed
the
loud
branch
2 times, most recently
from
7ff8f99 to
17ae026
Compare
|
Thanks, but why bother computing a logarithm only to compare it with a 0? That's a bit wasteful, no? |
Oh yeah sorry I was on glue. I initially planned to check for +1dBFS and then decided to go with 0 (which made more sense for counting overloads), and completely forgot to remove the log. I'll resubmit, checking for frame_pwr > 1.0 😅 |
This counter is increased for every good message above 0dBFS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #43 this adds a simple per-channel counter for (good) loud messages. A loud message is any message decoded above 0dBFS, to keep things simple.
HTH :)