Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve node matching #98

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Conversation

atanasdinov
Copy link
Contributor

@atanasdinov atanasdinov commented Oct 9, 2024

Closes #76

Signed-off-by: Atanas Dinov <atanas.dinov@suse.com>
Signed-off-by: Atanas Dinov <atanas.dinov@suse.com>
@atanasdinov atanasdinov marked this pull request as ready for review October 9, 2024 11:41
@atanasdinov atanasdinov requested a review from ipetrov117 October 9, 2024 11:41
@atanasdinov atanasdinov changed the title Fix node matching Improve node matching Oct 9, 2024
Copy link
Contributor

@ipetrov117 ipetrov117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great.

@atanasdinov atanasdinov merged commit 705093f into suse-edge:main Oct 10, 2024
2 checks passed
@atanasdinov atanasdinov deleted the fix-node-matching branch October 10, 2024 09:05
atanasdinov added a commit that referenced this pull request Dec 11, 2024
…y, annotations usage (#117)

* Use CustomValidator interface for webhook implementation (#97)

* Use CustomValidator interface for webhook implementation

Signed-off-by: Atanas Dinov <atanas.dinov@suse.com>

* Unify webhook register

Signed-off-by: Atanas Dinov <atanas.dinov@suse.com>

---------

Signed-off-by: Atanas Dinov <atanas.dinov@suse.com>

* Improve node matching (#98)

* Improve node matching during Kubernetes upgrades

Signed-off-by: Atanas Dinov <atanas.dinov@suse.com>

* Improve node matching during OS upgrades

Signed-off-by: Atanas Dinov <atanas.dinov@suse.com>

---------

Signed-off-by: Atanas Dinov <atanas.dinov@suse.com>

* Move away from using annotations in favour of labels (#100)

* Move to label usage

* Provide better readibility for label addition

* Bring back release as annotation

* Bump helm.sh/helm/v3 from 3.15.4 to 3.16.2 (#99)

Bumps [helm.sh/helm/v3](https://github.com/helm/helm) from 3.15.4 to 3.16.2.
- [Release notes](https://github.com/helm/helm/releases)
- [Commits](helm/helm@v3.15.4...v3.16.2)

---
updated-dependencies:
- dependency-name: helm.sh/helm/v3
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Reduce concurrency for OS SUC workers (#107)

* Reduce concurrency for OS SUC workers

* Fix unit tests

* K8s core component validation (#116)

* Add core component definitions in release manifest

* Align helm chart CRD indentations with kubebuilder generated CRD

* Introduce new release manifest CRD changes

* make generate

* Introduce container comparison logic

* Update variable name to improve reusability

* Add deployment monitoring permissions to reconciler

* Introduce helm release comparison function

* Update function to parse K8s distribution

* Introduce wait mechanism for K8s core components

* Fix typos

* Don't fail on job not found errors

* Check deployment staus conditions

* Fix typos

---------

Signed-off-by: Atanas Dinov <atanas.dinov@suse.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Ivo Petrov <ivo.petrov@suse.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade checks should not pass if selector doesn't match any nodes
2 participants