[ETHEREUM-CONRACTS] fix simple forwarder #2044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog ReminderReminder to update the CHANGELOG.md for any of the modified packages in this PR.
|
hellwolf
requested changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: SimpleForwarder is deployed by the constructor of Superfluid.
SimpleForwarder.forwardCallwas madeonlyOwnerfor no good reason, other than mitigating potential unspecified phishing type abuse. However this causes it not to work in deployments where Superfluid (host) is upgradable, which is all prod deployments.The tests didn't "see" this issue because the foundry deployer doesn't use an upgradable host instance.
Solution: remove the
onlyOwnerclause.Also
withdrawLostNativeTokenswas replaced by logic which makes it impossible for any native tokens to remain in SimpleForwarder. They either are taken by the target, or taken back by the sender, or the tx fails. TODO: add test coverage verifying this.