Skip to content

chore: align ci with local dev #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 25, 2025
Merged

chore: align ci with local dev #374

merged 4 commits into from
Apr 25, 2025

Conversation

juleswritescode
Copy link
Collaborator

@juleswritescode juleswritescode commented Apr 25, 2025

  • pin the rust toolchain to the version we use for the workspace
  • reuse just commands in CI
  • add steps where we print the versions of the tools used in CI
  • install sqlx-cli with just install-tools and just upgrade-tools
  • remove bun install from just upgrade-tools
  • fixed all issues from clippy

the rust-toolchain.toml file was weird – it complained for the longest time that cargo fmt wasn't available with the 1.86.0 version, but now it just works. Seems to be just buggy sometimes

@psteinroe psteinroe merged commit 55deb64 into main Apr 25, 2025
7 checks passed
@willruggiano
Copy link

willruggiano commented Apr 25, 2025

Have you guys ever dabbled with Nix? I have found that it excels at this sort of thing (i.e. dev/ci determinism/reproducibility).

There is a great blog post that was written primarily about building Docker images using Nix, but the sentiment applies to CI in general. But alas I am heavily invested and thus heavily biased :D

Anyways, if you are interested I'd be more than happy to discuss in detail with you. Or even if you aren't but are nonetheless curious! Thought I'd toss it out there considering I just went through a similar exercise in a repository of my own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants