V3 manifest: improve specificity, validation and tests #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ndushay
changed the title
ndushay
force-pushed
the
v3-manifest-tests
branch
2 times, most recently
from
afa6dd9 to
a596828
Compare
ndushay
force-pushed
the
v3-manifest-tests
branch
from
a596828 to
253c932
Compare
ndushay
force-pushed
the
v3-viewing-hint-validation
branch
from
8a58402 to
f863882
Compare
ndushay
force-pushed
the
v3-manifest-tests
branch
2 times, most recently
from
d42f5a3 to
839ae31
Compare
ndushay
changed the title
ndushay
force-pushed
the
v3-manifest-tests
branch
3 times, most recently
from
71081a5 to
7239741
Compare
ndushay
changed the title
ndushay
changed the title
15 tasks
ndushay
force-pushed
the
v3-manifest-tests
branch
from
7239741 to
314c79e
Compare
…otationCollection
ndushay
changed the title
tingulfsen
suggested changes
Jul 28, 2017
| subject['items'] = [seq] | ||
| subject['id'] = manifest_id | ||
| subject.label = 'Book 1' | ||
| expect { subject.validate }.not_to raise_error |
There was a problem hiding this comment.
How about having one test where there is a single sequence with no "label"? Or does that already exist elsewhere?
There was a problem hiding this comment.
a single sequence without a label is allowed. Labels are only required if there are multiple sequences.
There was a problem hiding this comment.
I know, my point is that we should have a test that has a single sequence without a label. To make sure our code does not always require labels.
tingulfsen
approved these changes
Jul 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connects to #6
This is now merge-able. These changes should not adversely affect purl code (as there are tests validating manifest building specifically akin to our purl code). I'm not sure this is so complex as to require multiple reviewers, so if you're comfortable with it, feel free to merge it.
I have relaxed the v3 documented spec requirements that won't work with UV. I did this as a separate commit.
The IIIF v3 requirement to use 'items' is documented in #27 and in sul-dlss/purl/issues/167.