Skip to content

Commit

Permalink
require ReleaseTag "what" attribute as part of cocina-models upgrade
Browse files Browse the repository at this point in the history
related:
* update dor_indexing gem
* fix tests to provide value for previously optional release tag field
* require 'csv' in a file that uses CSV.parse (registration_csv_converter_spec.rb started failing without this change)

goes with sul-dlss/cocina-models#697
  • Loading branch information
jmartin-sul committed Mar 30, 2024
1 parent 892a2b5 commit 5ed58cf
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 12 deletions.
4 changes: 2 additions & 2 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ git_source(:github) { |repo| "https://github.com/#{repo}.git" }
gem 'rails', '~> 7.1.0'

# DLSS/domain-specific dependencies
gem 'cocina-models', '~> 0.95.0'
gem 'cocina-models', '~> 0.96.0'
gem 'datacite', '~> 0.3.0'
gem 'dor_indexing', '~> 2.0'
gem 'dor_indexing', '~> 2.1'
gem 'dor-workflow-client', '~> 7.0'
gem 'druid-tools', '~> 2.2'
gem 'folio_client', '~> 0.8'
Expand Down
10 changes: 5 additions & 5 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ GEM
capistrano-bundler (>= 1.1, < 3)
capistrano-shared_configs (0.2.2)
chronic (0.10.2)
cocina-models (0.95.1)
cocina-models (0.96.0)
activesupport
deprecation
dry-struct (~> 1.0)
Expand Down Expand Up @@ -171,9 +171,9 @@ GEM
faraday-retry (~> 2.0)
nokogiri (~> 1.6)
zeitwerk (~> 2.1)
dor_indexing (2.0.1)
dor_indexing (2.1.0)
activesupport
cocina-models (~> 0.95.1)
cocina-models (~> 0.96.0)
dor-workflow-client (~> 7.0)
honeybadger
marc-vocab (~> 0.3.0)
Expand Down Expand Up @@ -580,7 +580,7 @@ DEPENDENCIES
capistrano-passenger
capistrano-rails
capistrano-shared_configs
cocina-models (~> 0.95.0)
cocina-models (~> 0.96.0)
committee
config
daemons
Expand All @@ -589,7 +589,7 @@ DEPENDENCIES
diffy
dlss-capistrano
dor-workflow-client (~> 7.0)
dor_indexing (~> 2.0)
dor_indexing (~> 2.1)
druid-tools (~> 2.2)
dry-monads
edtf (~> 3.0)
Expand Down
1 change: 1 addition & 0 deletions openapi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2688,6 +2688,7 @@ components:
additionalProperties: true
required:
- release
- what
properties:
who:
description: Who did this release
Expand Down
10 changes: 5 additions & 5 deletions spec/services/publish/public_xml_service_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -286,8 +286,8 @@
build(:dro, id: 'druid:bc123df4567').new(description:, administrative: {
hasAdminPolicy: 'druid:qv648vd4392',
releaseTags: [
{ to: 'Searchworks', release: true, date: '2015-10-23T21:49:29.000+00:00' },
{ to: 'PURL sitemap', release: true, date: '2015-10-23T21:49:29.000+00:00' }
{ to: 'Searchworks', release: true, date: '2015-10-23T21:49:29.000+00:00', what: 'self' },
{ to: 'PURL sitemap', release: true, date: '2015-10-23T21:49:29.000+00:00', what: 'self' }
]
})
end
Expand All @@ -308,9 +308,9 @@
build(:dro, id: 'druid:bc123df4567').new(description:, administrative: {
hasAdminPolicy: 'druid:qv648vd4392',
releaseTags: [
{ to: 'Searchworks', release: false, date: '2015-10-23T21:49:29.000+00:00' },
{ to: 'Searchworks', release: true, date: '2018-10-23T21:49:29.000+00:00' },
{ to: 'Some_special_place', release: true, date: '2015-10-23T21:49:29.000+00:00' }
{ to: 'Searchworks', release: false, date: '2015-10-23T21:49:29.000+00:00', what: 'self' },
{ to: 'Searchworks', release: true, date: '2018-10-23T21:49:29.000+00:00', what: 'self' },
{ to: 'Some_special_place', release: true, date: '2015-10-23T21:49:29.000+00:00', what: 'self' }
]
})
end
Expand Down

0 comments on commit 5ed58cf

Please sign in to comment.