Add default value for the partitionType to partition
#863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shibd
approved these changes
Jan 15, 2024
RobertIndie
added a commit
that referenced
this pull request
Jan 16, 2024
### Motivation In #845, we have deprecated `partitionerType` and recommand users to use `partitioner`. Set the default value of `partitionerType` to `partition`. So that we could be able to not configure it. Otherwise, it will raise exceptions if we don't configure it. ### Modifications - Add default value for the partitionType to `partition` (cherry picked from commit ba24f85)
shibd
added a commit
to shibd/pulsar-io-cloud-storage
that referenced
this pull request
Oct 17, 2024
…mnative#863)" This reverts commit ba24f85.
3 tasks
shibd
added a commit
that referenced
this pull request
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #845, we have deprecated
partitionerTypeand recommand users to usepartitioner.Set the default value of
partitionerTypetopartition. So that we could be able to not configure it. Otherwise, it will raise exceptions if we don't configure it.Modifications
partitionVerifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)