Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop support for Python 3.8 #3730

Merged
merged 4 commits into from
Dec 21, 2024
Merged

feat: drop support for Python 3.8 #3730

merged 4 commits into from
Dec 21, 2024

Conversation

bellini666
Copy link
Member

@bellini666 bellini666 commented Dec 18, 2024

Python 3.8 has reached EOL a couple of months ago, it's time to drop support for it.

https://devguide.python.org/versions/

Screenshot 2024-12-18 at 21 03 27

@bellini666 bellini666 self-assigned this Dec 18, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request #3730 has too many files changed.

We can only review pull requests with up to 300 changed files, and this pull request has 303.

@botberry
Copy link
Member

botberry commented Dec 18, 2024

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🔲
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

@botberry
Copy link
Member

botberry commented Dec 18, 2024

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:


This release drops support for Python 3.8, which reached its end-of-life (EOL)
in October 2024. The minimum supported Python version is now 3.9.

We strongly recommend upgrading to Python 3.9 or a newer version, as older
versions are no longer maintained and may contain security vulnerabilities.

Here's the tweet text:

🆕 Release (next) is out! Thanks to @_bellini666 for the PR 👏

Get it here 👉 https://strawberry.rocks/release/(next)

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 99.57717% with 4 lines in your changes missing coverage. Please review.

Project coverage is 97.12%. Comparing base (0981661) to head (f5e224d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3730      +/-   ##
==========================================
+ Coverage   96.97%   97.12%   +0.14%     
==========================================
  Files         504      503       -1     
  Lines       33768    33524     -244     
  Branches     5639     5507     -132     
==========================================
- Hits        32748    32561     -187     
+ Misses        810      756      -54     
+ Partials      210      207       -3     

Python 3.8 has reached EOL a couple of months ago, it's time to drop support for it.
Copy link

codspeed-hq bot commented Dec 18, 2024

CodSpeed Performance Report

Merging #3730 will not alter performance

Comparing py39 (f5e224d) with main (0981661)

Summary

✅ 21 untouched benchmarks

@bellini666 bellini666 force-pushed the py39 branch 2 times, most recently from b6105b7 to 3f01cdf Compare December 21, 2024 12:38
@bellini666 bellini666 merged commit 5c6f367 into main Dec 21, 2024
94 checks passed
@bellini666 bellini666 deleted the py39 branch December 21, 2024 13:27
@DoctorJohn DoctorJohn mentioned this pull request Dec 24, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants