fix(story-badge): prevent signature replay in StoryBadgeNFT minting
#182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebsadface
requested review from
kingster-will,
Spablob and
LeoHChen
as code owners
kingster-will
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a security vulnerability in the StoryBadgeNFT contract where signatures could be reused across different organizations' StoryBadgeNFT contracts if they share the same signer address. The fix modifies the signature digest in
StoryBadgeNFT.solto include both the recipient's address (msg.sender) and the contract address (address(this)), preventing signature replay attacks between different StoryBadgeNFT contracts.Changes
StoryBadgeNFT.sol_signAddress()to support new signature format