Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.4.2 #62

Merged
merged 29 commits into from
Mar 12, 2024
Merged

v0.4.2 #62

merged 29 commits into from
Mar 12, 2024

Conversation

henriquesposito
Copy link
Contributor

@henriquesposito henriquesposito commented Mar 11, 2024

Description

This PR fixes bugs with autographr() and autographd() functions.

Making

Mapping

Modifying

  • Updated to_reciprocated.matrix() to consistently work with matrices

Checklist:

  • PR form
    • Description above itemizes changes under subtitles, e.g. "## Data""
    • Any closed, fixed, or related issues are referenced and explained in the description above, e.g. "Fixed #0 by adding A"
    • Package builds on my OS without issues
  • PR checks all pass for latest commit
    • CodeFactor check: Package improves or maintains good style
    • Package builds on Mac
    • Package builds on Windows
    • Package builds on Linux
    • CodeCov check: Package improves or maintains good test coverage
  • Documentation
    • Any new or modified functions or data have roxygen style documentation in their .R scripts
    • Longer functions are commented inline or broken down into helper functions so that it is easier to debug in the future
    • PR description above and the NEWS.md file are aligned
    • DESCRIPTION file version is bumped by the appropriate increment (major, minor, patch)

jhollway and others added 23 commits January 25, 2024 09:40
…d to be more flexible in accepting variables and values when plotting.
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 37.16814% with 71 lines in your changes are missing coverage. Please review.

Project coverage is 48.19%. Comparing base (1141114) to head (278ea9b).
Report is 2 commits behind head on main.

Files Patch % Lines
R/map_autographr.R 35.59% 38 Missing ⚠️
R/map_theme.R 29.72% 26 Missing ⚠️
R/map_layout_configurations.R 0.00% 4 Missing ⚠️
R/make_play.R 0.00% 2 Missing ⚠️
R/make_generate.R 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   47.93%   48.19%   +0.25%     
==========================================
  Files          27       27              
  Lines        3605     3567      -38     
==========================================
- Hits         1728     1719       -9     
+ Misses       1877     1848      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henriquesposito henriquesposito requested a review from jaeltan March 11, 2024 17:11
@henriquesposito henriquesposito self-assigned this Mar 11, 2024
Copy link
Contributor

@jaeltan jaeltan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Henrique for all the great work on the graphing layouts!

@henriquesposito henriquesposito merged commit da790ef into main Mar 12, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants