-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Any feature branch should always self-test against itself #6
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
=======================================
Coverage 98.93% 98.93%
=======================================
Files 6 6
Lines 187 187
=======================================
Hits 185 185
Misses 2 2 ☔ View full report in Codecov by Sentry. |
Integration Test / self-test will fail for this PR. The self test builds the action from the These changes are proven to work in stfc/cloud-docker-images#103 |
|
Remove src from import path as it is not a package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can understand these changes, they look OK to me.
Increase patch version as the changes fix a bug but do not introduce functionality
This should reduce the amount of tests running in the pull request
This should make PRs more informative and help reminder authors/reviewers what needs to be done
Description:
Fixing bug in action where the main.py cannot import from src. Removing src from import path fixes this.
Additionally:
Created a PR template
Changed workflows to only run workflows on push if the branch is main
Submitter:
Have you done the following?:
major | minor | patch
ordocumentation | workflow
version.txt
anddocker-compose.yml
files?Reviewer:
Have you checked the following?: