-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(towards #2577) Add support for pointer assignments #2583
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2583 +/- ##
==========================================
- Coverage 99.86% 99.85% -0.01%
==========================================
Files 351 352 +1
Lines 48396 48455 +59
==========================================
+ Hits 48331 48386 +55
- Misses 65 69 +4 ☔ View full report in Codecov by Sentry. |
5d7154c
to
f721bac
Compare
This is ready for a first look from @arporter or @hiker . It adds support for pointer assignments (removes the CodeBlocks), but not symbol attributes (does not remove UnknownFortranType for its symbols). It also adds support in the frontend for Fortran2003.Data_Pointer_Object fparser object. For now I added some broad protections in the base loop_trans and region_trans to prevent transformation to apply to code that have pointer assignments (which can be disabled with a transformation option). |
1bfd464
to
01807d4
Compare
@arporter This is ready for next review. In comparison to the first review I found out that pointer expressions that have array accessor ranges in the inner element are not described like regular arrays in the standard/fparser. So I decided to not support these cases yet - they are CodeBlocks as before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there. A few small things to tidy and there's a conflict with mlc_config
because it has been removed on master.
Ref. guide still builds fine.
I'll launch the integration tests.
src/psyclone/tests/psyir/frontend/fparser2_derived_type_test.py
Outdated
Show resolved
Hide resolved
@arporter This is ready for another review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Virtually) all requested changes have been made. I'll take the liberty of fixing the remaining typo.
I've checked the Dev and User Guides and they don't require updating.
Integration tests were all green.
Will proceed to merge.
No description provided.