Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(towards #2577) Add support for pointer assignments #2583

Merged
merged 18 commits into from
Jul 2, 2024

Conversation

sergisiso
Copy link
Collaborator

No description provided.

@sergisiso sergisiso self-assigned this May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.85%. Comparing base (4d10caa) to head (09d4cec).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2583      +/-   ##
==========================================
- Coverage   99.86%   99.85%   -0.01%     
==========================================
  Files         351      352       +1     
  Lines       48396    48455      +59     
==========================================
+ Hits        48331    48386      +55     
- Misses         65       69       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergisiso sergisiso force-pushed the 2577_support_pointer_assignments branch from 5d7154c to f721bac Compare June 23, 2024 20:13
@sergisiso
Copy link
Collaborator Author

This is ready for a first look from @arporter or @hiker . It adds support for pointer assignments (removes the CodeBlocks), but not symbol attributes (does not remove UnknownFortranType for its symbols). It also adds support in the frontend for Fortran2003.Data_Pointer_Object fparser object. For now I added some broad protections in the base loop_trans and region_trans to prevent transformation to apply to code that have pointer assignments (which can be disabled with a transformation option).

@sergisiso
Copy link
Collaborator Author

@arporter This is ready for next review. In comparison to the first review I found out that pointer expressions that have array accessor ranges in the inner element are not described like regular arrays in the standard/fparser. So I decided to not support these cases yet - they are CodeBlocks as before.

Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there. A few small things to tidy and there's a conflict with mlc_config because it has been removed on master.
Ref. guide still builds fine.
I'll launch the integration tests.

@sergisiso
Copy link
Collaborator Author

@arporter This is ready for another review

Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Virtually) all requested changes have been made. I'll take the liberty of fixing the remaining typo.
I've checked the Dev and User Guides and they don't require updating.
Integration tests were all green.
Will proceed to merge.

@arporter arporter merged commit 05955d1 into master Jul 2, 2024
12 checks passed
@arporter arporter deleted the 2577_support_pointer_assignments branch July 2, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants