(Towards 2421) Suggested fix to inline trans

[LonelyCat124]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ff8992) 99.84% compared to head (3d1c115) 99.84%.

❗ Current head 3d1c115 differs from pull request most recent head 1ad9e42. Consider uploading reports for the commit 1ad9e42 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2430      +/-   ##
==========================================
- Coverage   99.84%   99.84%   -0.01%     
==========================================
  Files         350      350              
  Lines       47265    47272       +7     
==========================================
+ Hits        47194    47200       +6     
- Misses         71       72       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[LonelyCat124]

@arporter This is my proposed fix for the issues I had with inlining, which should enable more general usage for parallel loops.

[arporter]

For some reason, github isn't letting me complete my review properly. The fix looks fine. I think it just needs some comments and an explicit (new) test of the bug that is being fixed. I'll trigger the integration tests now. Note that I've merged master into the branch so you'll need to pull before you work on it.

[LonelyCat124]

@arporter I added a test to explicitly check this and some comments - let me know if you feel they're enough or is there's anything I've missed.

[LonelyCat124]

I'm confused as to why this reports a loss in coverage though? Nothing I've changed should touch the OMPParallelDirective

[arporter]

Thanks for those changes. All looks good now and integration tests were fine.
Will proceed to merge.