Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1990 handle imported variable in kernel extraction #2252

Merged
merged 218 commits into from
May 13, 2024

Conversation

hiker
Copy link
Collaborator

@hiker hiker commented Aug 8, 2023

Fixes #1990

hiker added 30 commits January 24, 2023 13:33
…90_handle_imported_variable_in_kernel_extraction
Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there now. Main thing is to check what Stylist actually checks in LFRic and use this information in a comment to justify the removal of 'private/protected' clauses. Apart from that there are some minor things to tidy. Updated User Guide builds fine, as does Reference Guide.
Examples are all fine with compilation enabled (although this is checked by the integration tests anyway).

config/psyclone.cfg Outdated Show resolved Hide resolved
src/psyclone/domain/lfric/lfric_extract_driver_creator.py Outdated Show resolved Hide resolved
src/psyclone/domain/lfric/lfric_extract_driver_creator.py Outdated Show resolved Hide resolved
src/psyclone/psyir/nodes/extract_node.py Outdated Show resolved Hide resolved
src/psyclone/psyir/nodes/extract_node.py Show resolved Hide resolved
src/psyclone/psyir/nodes/psy_data_node.py Outdated Show resolved Hide resolved
src/psyclone/psyir/nodes/psy_data_node.py Show resolved Hide resolved
src/psyclone/psyir/nodes/psy_data_node.py Outdated Show resolved Hide resolved
src/psyclone/tests/psyir/nodes/extract_node_test.py Outdated Show resolved Hide resolved
@hiker
Copy link
Collaborator Author

hiker commented May 9, 2024

My apologies for first discussing the need to remove private/protected - given the progress I've made with FAB, I've decided to just not include this anymore, so I hope a major concern for you is gone :) I've also updated the documentation correspondingly.

I am triggering CI now, then it should be ready for next review.

@hiker hiker temporarily deployed to integration May 9, 2024 05:27 — with GitHub Actions Inactive
Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good now, thanks Joerg.
I've brought the branch up to master and I've fired off those integration tests that currently work (i.e. not LFRic unfortunately).
If that's all fine then this is ready to go.

@arporter
Copy link
Member

Integration tests were green.

@arporter arporter merged commit a440b4c into master May 13, 2024
10 of 11 checks passed
@arporter arporter deleted the 1990_handle_imported_variable_in_kernel_extraction branch May 13, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kernel extraction driver: handle values imported from other modules
3 participants