-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1990 handle imported variable in kernel extraction #2252
1990 handle imported variable in kernel extraction #2252
Conversation
…ted_variable_in_kernel_extraction
…ted_variable_in_kernel_extraction
…ted_variable_in_kernel_extraction
…ted_variable_in_kernel_extraction
…ted_variable_in_kernel_extraction
…ted_variable_in_kernel_extraction
…ted_variable_in_kernel_extraction
…90_handle_imported_variable_in_kernel_extraction
…ted_variable_in_kernel_extraction
…ted_variable_in_kernel_extraction
…ted_variable_in_kernel_extraction
…ted_variable_in_kernel_extraction
…ted_variable_in_kernel_extraction
…ted_variable_in_kernel_extraction
…ted_variable_in_kernel_extraction
…ted_variable_in_kernel_extraction
…ted_variable_in_kernel_extraction
…veral routines.
…d_variable_in_kernel_extraction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there now. Main thing is to check what Stylist actually checks in LFRic and use this information in a comment to justify the removal of 'private/protected' clauses. Apart from that there are some minor things to tidy. Updated User Guide builds fine, as does Reference Guide.
Examples are all fine with compilation enabled (although this is checked by the integration tests anyway).
…d_variable_in_kernel_extraction
My apologies for first discussing the need to remove private/protected - given the progress I've made with FAB, I've decided to just not include this anymore, so I hope a major concern for you is gone :) I've also updated the documentation correspondingly. I am triggering CI now, then it should be ready for next review. |
…d_variable_in_kernel_extraction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good now, thanks Joerg.
I've brought the branch up to master and I've fired off those integration tests that currently work (i.e. not LFRic unfortunately).
If that's all fine then this is ready to go.
Integration tests were green. |
Fixes #1990