fix(authz): client and service account mess #1216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bobeal
commented
Aug 9, 2024
bobeal
commented
- no more create events (client events are only sent when adding or removing a role)
- no more event for serviceAccountId (it is now always used as the id of the pseudo-entity)
- handle event to replace clientId and store it in subject info through already existing attribute replace event
Test Results 61 files ±0 61 suites ±0 1m 35s ⏱️ +8s For more details on these failures, see this check. Results for commit 1ad586f. ± Comparison against base commit ae182d4. |
thomasBousselin
force-pushed
the
refacto/search-service
branch
from
ae182d4 to
5b70c5a
Compare
- no more create events (client events are only sent when adding or removing a role) - no more event for serviceAccountId (it is now always used as the id of the pseudo-entity) - handle event to replace clientId and store it in subject info through already existing attribute replace event
bobeal
force-pushed
the
fix/client-and-service-account-mess
branch
from
1ad586f to
f0e7ea0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.