Soroban contract init followup #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the example contract is invalid
elizabethengelman
force-pushed
the
soroban-contract-init-followup
branch
from
a9c4c59 to
ef4902b
Compare
* Remove panic - 1 * Remove panic - 2 * Remove panic - 3 * Remove panic - 4 * Small changes - 1 * undo changes in Get() func * undo changes - 2 * undo changes - 3 * add test for append error
elizabethengelman
force-pushed
the
soroban-contract-init-followup
branch
from
ef4902b to
5517a65
Compare
chadoh
approved these changes
Feb 1, 2024
Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com>
elizabethengelman
force-pushed
the
soroban-contract-init-followup
branch
from
7093762 to
4d797c5
Compare
psheth9
pushed a commit
that referenced
this pull request
Feb 7, 2024
* Upgrade gix version to 0.58.0 * Add frontend template option * Use a custom value_parser for with_examples * Pull possible example contracts from soroban-examples repo * Check if there is an internet connection and handle if not --------- Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR acts as a follow up for PR #1156, handling comments that weren't initially handled in the original PR:
--frontend-templateflagadd a fuzz test / fuzz setup exampleI'm leaning toward omitting the fuzzing example from being included by default in the initialized project, since this is a more advanced topic. Users will still be able to include it with the--with-exampleflag.add an optionalAlso leaning toward omitting this, which was based on a comment in the previous PR. Since the base structure of the rust template is pretty bare-bones, I'm hoping it will be sufficient for lots of use cases to start. And then users will be able to expand the base project by adding examples contracts (--templateflag--with-examples) and a frontend template (--frontend-template).