-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_: refactor default messaging scenario #6351
Conversation
Jenkins BuildsClick to see older builds (16)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, left 2 comments
Also I think TestLightClientMessaging doesn't need
@pytest.mark.usefixtures("setup_two_privileged_nodes")
can you please check and remove it if the test passes without it?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6351 +/- ##
===========================================
- Coverage 59.69% 59.63% -0.07%
===========================================
Files 865 865
Lines 113050 113050
===========================================
- Hits 67484 67413 -71
- Misses 37731 37778 +47
- Partials 7835 7859 +24
Flags with carried forward coverage won't be shown. Click here to find out more. |
28a7234
to
0ed58d9
Compare
1st contribution :)
Important changes:
wakuext_sendOneToOneMessage
TestDefaultMessaging
into separate fileTestRpc