Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_: refactor default messaging scenario #6351

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

rlve
Copy link
Contributor

@rlve rlve commented Feb 19, 2025

1st contribution :)

Important changes:

  • add json schema verification for wakuext_sendOneToOneMessage
  • split TestDefaultMessaging into separate file
  • refactor naming of TestRpc

@rlve rlve requested a review from fbarbu15 February 19, 2025 09:41
@status-im-auto
Copy link
Member

status-im-auto commented Feb 19, 2025

Jenkins Builds

Click to see older builds (16)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 7d0427b #1 2025-02-19 09:42:08 ~2 min ios 📦zip
✔️ 7d0427b #1 2025-02-19 09:42:19 ~3 min android 📦aar
✔️ 7d0427b #1 2025-02-19 09:43:44 ~4 min macos 📦zip
✔️ 7d0427b #1 2025-02-19 09:44:28 ~5 min windows 📦zip
✔️ 7d0427b #1 2025-02-19 09:44:36 ~5 min macos 📦zip
✔️ 7d0427b #1 2025-02-19 09:45:08 ~5 min linux 📦zip
✔️ 7d0427b #1 2025-02-19 09:52:21 ~13 min tests-rpc 📄log
✔️ 7d0427b #1 2025-02-19 10:10:59 ~31 min tests 📄log
✔️ ca65e95 #2 2025-02-19 11:59:21 ~2 min ios 📦zip
✔️ ca65e95 #2 2025-02-19 11:59:50 ~3 min android 📦aar
✔️ ca65e95 #2 2025-02-19 12:00:04 ~3 min macos 📦zip
✔️ ca65e95 #2 2025-02-19 12:01:37 ~4 min windows 📦zip
✔️ ca65e95 #2 2025-02-19 12:01:47 ~5 min macos 📦zip
✔️ ca65e95 #2 2025-02-19 12:03:38 ~7 min linux 📦zip
✔️ ca65e95 #2 2025-02-19 12:09:11 ~12 min tests-rpc 📄log
✔️ ca65e95 #2 2025-02-19 12:28:27 ~31 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 0ed58d9 #3 2025-02-19 12:02:02 ~2 min ios 📦zip
✔️ 0ed58d9 #3 2025-02-19 12:03:24 ~3 min android 📦aar
✔️ 0ed58d9 #3 2025-02-19 12:03:45 ~3 min macos 📦zip
✔️ 0ed58d9 #3 2025-02-19 12:05:25 ~3 min windows 📦zip
✔️ 0ed58d9 #3 2025-02-19 12:07:00 ~5 min macos 📦zip
✔️ 0ed58d9 #3 2025-02-19 12:08:51 ~5 min linux 📦zip
✖️ 0ed58d9 #3 2025-02-19 12:20:49 ~11 min tests-rpc 📄log
✔️ 0ed58d9 #3 2025-02-19 12:58:56 ~30 min tests 📄log
✔️ d8a3248 #4 2025-02-19 12:38:53 ~2 min ios 📦zip
✔️ d8a3248 #4 2025-02-19 12:39:13 ~3 min android 📦aar
✔️ d8a3248 #4 2025-02-19 12:39:36 ~3 min windows 📦zip
✔️ d8a3248 #4 2025-02-19 12:39:39 ~3 min macos 📦zip
✔️ d8a3248 #4 2025-02-19 12:41:19 ~5 min macos 📦zip
✔️ d8a3248 #4 2025-02-19 12:41:28 ~5 min linux 📦zip
✔️ d8a3248 #4 2025-02-19 12:48:11 ~11 min tests-rpc 📄log
✔️ d8a3248 #4 2025-02-19 13:30:26 ~31 min tests 📄log

Copy link
Contributor

@fbarbu15 fbarbu15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, left 2 comments

Also I think TestLightClientMessaging doesn't need
@pytest.mark.usefixtures("setup_two_privileged_nodes")
can you please check and remove it if the test passes without it?

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.63%. Comparing base (1bfb0ce) to head (d8a3248).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6351      +/-   ##
===========================================
- Coverage    59.69%   59.63%   -0.07%     
===========================================
  Files          865      865              
  Lines       113050   113050              
===========================================
- Hits         67484    67413      -71     
- Misses       37731    37778      +47     
- Partials      7835     7859      +24     
Flag Coverage Δ
functional 0.45% <ø> (ø)
unit 59.62% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 33 files with indirect coverage changes

@rlve rlve force-pushed the test-refactor-default-messaging branch 3 times, most recently from 28a7234 to 0ed58d9 Compare February 19, 2025 11:59
@fbarbu15 fbarbu15 marked this pull request as ready for review February 19, 2025 13:14
@rlve rlve merged commit 873e93a into develop Feb 20, 2025
19 checks passed
@rlve rlve deleted the test-refactor-default-messaging branch February 20, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants