Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore_: reorganize thirdparty dir into categories #6349

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

dlipicar
Copy link
Contributor

Simple reorganization of thirdparty provider modules into directories

  • collectibles
  • decoder
  • market

New category activity coming soon, with a provider also used for collectibles

@dlipicar dlipicar requested a review from a team February 17, 2025 18:14
@status-im-auto
Copy link
Member

status-im-auto commented Feb 17, 2025

Jenkins Builds

Click to see older builds (8)
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ edf0768 #1 2025-02-17 18:15:45 ~1 min tests 📄log
✔️ edf0768 #1 2025-02-17 18:17:07 ~2 min android 📦aar
✔️ edf0768 #1 2025-02-17 18:17:48 ~3 min ios 📦zip
✔️ edf0768 #1 2025-02-17 18:18:12 ~3 min macos 📦zip
✔️ edf0768 #1 2025-02-17 18:19:27 ~5 min linux 📦zip
✔️ edf0768 #1 2025-02-17 18:20:27 ~6 min macos 📦zip
✔️ edf0768 #1 2025-02-17 18:21:15 ~6 min windows 📦zip
✔️ edf0768 #1 2025-02-17 18:26:08 ~11 min tests-rpc 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ f34e8cc #2 2025-02-17 18:17:46 ~1 min tests 📄log
✔️ f34e8cc #2 2025-02-17 18:20:10 ~2 min android 📦aar
✔️ f34e8cc #2 2025-02-17 18:20:38 ~2 min ios 📦zip
✔️ f34e8cc #2 2025-02-17 18:22:11 ~3 min macos 📦zip
✔️ f34e8cc #2 2025-02-17 18:24:48 ~5 min linux 📦zip
✔️ f34e8cc #2 2025-02-17 18:26:01 ~5 min macos 📦zip
✔️ f34e8cc #2 2025-02-17 18:26:47 ~5 min windows 📦zip
✔️ 5fd85ad #3 2025-02-17 18:27:50 ~2 min ios 📦zip
✔️ 5fd85ad #3 2025-02-17 18:28:06 ~3 min android 📦aar
✔️ 5fd85ad #3 2025-02-17 18:28:57 ~3 min macos 📦zip
✔️ 5fd85ad #3 2025-02-17 18:30:25 ~5 min linux 📦zip
✔️ 5fd85ad #3 2025-02-17 18:30:43 ~3 min windows 📦zip
✔️ 5fd85ad #3 2025-02-17 18:32:16 ~6 min macos 📦zip
✔️ 5fd85ad #2 2025-02-17 18:37:44 ~11 min tests-rpc 📄log
✖️ 5fd85ad #3 2025-02-17 18:56:32 ~31 min tests 📄log
✔️ 5fd85ad #4 2025-02-17 19:48:42 ~32 min tests 📄log

@dlipicar dlipicar force-pushed the dlipicar/reorg-thirdparty-dir branch from edf0768 to f34e8cc Compare February 17, 2025 18:15
@dlipicar dlipicar force-pushed the dlipicar/reorg-thirdparty-dir branch from f34e8cc to 5fd85ad Compare February 17, 2025 18:24
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.60%. Comparing base (b2cd7bd) to head (5fd85ad).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6349      +/-   ##
===========================================
- Coverage    59.67%   59.60%   -0.07%     
===========================================
  Files          865      865              
  Lines       112981   112981              
===========================================
- Hits         67418    67343      -75     
- Misses       37727    37786      +59     
- Partials      7836     7852      +16     
Flag Coverage Δ
functional 0.45% <ø> (ø)
unit 59.60% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
services/wallet/decoder.go 44.44% <ø> (ø)
services/wallet/service.go 88.68% <ø> (ø)
services/wallet/thirdparty/collectible_types.go 84.88% <ø> (ø)
...s/wallet/thirdparty/collectibles/alchemy/client.go 34.88% <ø> (ø)
...es/wallet/thirdparty/collectibles/alchemy/types.go 72.38% <ø> (ø)
...allet/thirdparty/collectibles/opensea/client_v2.go 25.14% <ø> (ø)
...let/thirdparty/collectibles/opensea/http_client.go 40.00% <ø> (ø)
...wallet/thirdparty/collectibles/opensea/types_v2.go 16.36% <ø> (ø)
...s/wallet/thirdparty/collectibles/rarible/client.go 19.59% <ø> (ø)
...es/wallet/thirdparty/collectibles/rarible/types.go 66.66% <ø> (ø)
... and 4 more

... and 30 files with indirect coverage changes

@dlipicar dlipicar merged commit b1ed4db into develop Feb 20, 2025
18 of 19 checks passed
@dlipicar dlipicar deleted the dlipicar/reorg-thirdparty-dir branch February 20, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants