draft - mark metric updates for broadcast messages

starkware-libs · Feb 10, 2025 · d04b599 · d04b599
1 parent b187b68
commit d04b599
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/crates/papyrus_network/src/network_manager/mod.rs b/crates/papyrus_network/src/network_manager/mod.rs
@@ -523,6 +523,7 @@ impl<SwarmT: SwarmTrait> GenericNetworkManager<SwarmT> {
         &mut self,
         event: gossipsub_impl::ExternalEvent,
     ) -> Result<(), NetworkError> {
+        // received broadcast message
         let gossipsub_impl::ExternalEvent::Received { originated_peer_id, message, topic_hash } =
             event;
         let broadcasted_message_metadata = BroadcastedMessageMetadata {
@@ -596,6 +597,7 @@ impl<SwarmT: SwarmTrait> GenericNetworkManager<SwarmT> {
     }
 
     fn broadcast_message(&mut self, message: Bytes, topic_hash: TopicHash) {
+        // update sent messages metric
         self.swarm.broadcast_message(message, topic_hash);
     }
 

diff --git a/crates/starknet_consensus_manager/src/consensus_manager.rs b/crates/starknet_consensus_manager/src/consensus_manager.rs
@@ -61,6 +61,7 @@ impl ConsensusManager {
             return std::future::pending().await;
         }
 
+        // TODO(alonl): consider splitting the metrics by topic
         let network_manager_metrics = Some(NetworkManagerMetrics {
             num_connected_peers: CONSENSUS_NUM_CONNECTED_PEERS,
             num_active_inbound_sessions: CONSENSUS_NUM_ACTIVE_INBOUND_SESSIONS,

diff --git a/crates/starknet_mempool_p2p/src/propagator/mod.rs b/crates/starknet_mempool_p2p/src/propagator/mod.rs
@@ -68,14 +68,17 @@ impl ComponentRequestHandler<MempoolP2pPropagatorRequest, MempoolP2pPropagatorRe
                         );
                         Ok(())
                     });
+                // increment number of sent messages
                 MempoolP2pPropagatorResponse::AddTransaction(result)
             }
             MempoolP2pPropagatorRequest::ContinuePropagation(propagation_manager) => {
+                // increment number of received messages
                 let result = self
                     .broadcast_topic_client
                     .continue_propagation(&propagation_manager)
                     .await
                     .map_err(|_| MempoolP2pPropagatorError::NetworkSendError);
+                // increment number of sent messages
                 MempoolP2pPropagatorResponse::ContinuePropagation(result)
             }
         }