-
Notifications
You must be signed in to change notification settings - Fork 603
Using all upcasts and downcasts variants. #7668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a0f69ae
to
659a2e9
Compare
41bfa49
to
9065fab
Compare
0893e10
to
b0ff58b
Compare
4eea8df
to
2893f03
Compare
fd4cd7b
to
c65098c
Compare
dd55192
to
e8d42d4
Compare
c65098c
to
966d7f0
Compare
966d7f0
to
b84e569
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 4 files at r1, all commit messages.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion
crates/cairo-lang-runner/src/profiling_test_data/major_test_cases
line 1143 at r1 (raw file):
function core::Felt252PartialEq::eq: 3 function core::starknet::testing::set_caller_address: 3 function unknown: 2
Any idea why it is unknown?
Code quote:
function unknown: 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)
crates/cairo-lang-runner/src/profiling_test_data/major_test_cases
line 1143 at r1 (raw file):
Previously, gilbens-starkware (Gil Ben-Shachar) wrote…
Any idea why it is unknown?
const-statement does not contain a location by itself, it has location by previous statements, and this one was probably first.
b84e569
to
620014b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 4 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @orizi)
commit-id:09d534d5
620014b
to
344361f
Compare
Stack: