Skip to content

Using all upcasts and downcasts variants. #7668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2025
Merged

Using all upcasts and downcasts variants. #7668

merged 1 commit into from
Apr 20, 2025

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Apr 16, 2025

@reviewable-StarkWare
Copy link

This change is Reviewable

@orizi orizi requested a review from gilbens-starkware April 16, 2025 14:53
@orizi orizi force-pushed the spr/main/09d534d5 branch from a0f69ae to 659a2e9 Compare April 17, 2025 17:39
@orizi orizi force-pushed the spr/main/638c847c branch 2 times, most recently from 41bfa49 to 9065fab Compare April 17, 2025 22:02
@orizi orizi force-pushed the spr/main/09d534d5 branch 2 times, most recently from 0893e10 to b0ff58b Compare April 17, 2025 22:21
@orizi orizi force-pushed the spr/main/638c847c branch 2 times, most recently from 4eea8df to 2893f03 Compare April 18, 2025 12:51
@orizi orizi force-pushed the spr/main/09d534d5 branch 2 times, most recently from fd4cd7b to c65098c Compare April 18, 2025 13:18
@orizi orizi force-pushed the spr/main/638c847c branch 2 times, most recently from dd55192 to e8d42d4 Compare April 20, 2025 11:32
@orizi orizi force-pushed the spr/main/09d534d5 branch from c65098c to 966d7f0 Compare April 20, 2025 11:32
@orizi orizi force-pushed the spr/main/09d534d5 branch from 966d7f0 to b84e569 Compare April 20, 2025 11:51
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 4 files at r1, all commit messages.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion


crates/cairo-lang-runner/src/profiling_test_data/major_test_cases line 1143 at r1 (raw file):

  function core::Felt252PartialEq::eq: 3
  function core::starknet::testing::set_caller_address: 3
  function unknown: 2

Any idea why it is unknown?

Code quote:

 function unknown: 2

Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)


crates/cairo-lang-runner/src/profiling_test_data/major_test_cases line 1143 at r1 (raw file):

Previously, gilbens-starkware (Gil Ben-Shachar) wrote…

Any idea why it is unknown?

const-statement does not contain a location by itself, it has location by previous statements, and this one was probably first.

@orizi orizi force-pushed the spr/main/09d534d5 branch from b84e569 to 620014b Compare April 20, 2025 12:09
@orizi orizi changed the base branch from spr/main/638c847c to main April 20, 2025 12:09
@orizi orizi enabled auto-merge April 20, 2025 12:11
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi force-pushed the spr/main/09d534d5 branch from 620014b to 344361f Compare April 20, 2025 14:09
@orizi orizi added this pull request to the merge queue Apr 20, 2025
Merged via the queue into main with commit 635b060 Apr 20, 2025
49 checks passed
@orizi orizi deleted the spr/main/09d534d5 branch April 22, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants