added validations for traitItemInfo

[dean-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dean-starkware]

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion

---

a discussion (no related file):
Note that support for impl will be submitted in a different PR.

[orizi]

Reviewed 1 of 3 files at r2, 1 of 3 files at r3.
Reviewable status: 1 of 7 files reviewed, 4 unresolved discussions (waiting on @gilbens-starkware)

---

crates/cairo-lang-semantic/src/items/feature_kind.rs line 78 at r2 (raw file):

    /// Returns the `FeatureKind` associated with the implementing struct.
    fn get_feature_kind(&self) -> FeatureKind;
}

Suggestion:

/// A trait for retrieving the `FeatureKind` of an item.
pub trait HasFeatureKind {
    /// Returns the `FeatureKind` associated with the implementing struct.
    fn feature_kind(&self) -> FeatureKind;
}

---

crates/cairo-lang-semantic/src/expr/compute.rs line 2846 at r2 (raw file):

    };
    let func_name = segment.identifier(syntax_db);
    let generic_args_syntax: Option<Vec<ast::GenericArg>> = segment.generic_args(syntax_db);

revert

---

crates/cairo-lang-semantic/src/expr/compute.rs line 2896 at r2 (raw file):

        )?;

    // Validate if the function is usable before inserting it into `used_items`.

useless doc - especially the second part.re

Code quote:

    // Validate if the function is usable before inserting it into `used_items`.

[dean-starkware]

Reviewable status: 1 of 7 files reviewed, 4 unresolved discussions (waiting on @gilbens-starkware and @orizi)

---

crates/cairo-lang-semantic/src/expr/compute.rs line 2846 at r2 (raw file):

Previously, orizi wrote…

revert

Done.

---

crates/cairo-lang-semantic/src/expr/compute.rs line 2896 at r2 (raw file):

Previously, orizi wrote…

useless doc - especially the second part.re

Done.

---

crates/cairo-lang-semantic/src/items/feature_kind.rs line 78 at r2 (raw file):

    /// Returns the `FeatureKind` associated with the implementing struct.
    fn get_feature_kind(&self) -> FeatureKind;
}

Done.

[orizi]

Reviewed 1 of 3 files at r3, 5 of 7 files at r4, all commit messages.
Reviewable status: 7 of 9 files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware)

---

crates/cairo-lang-semantic/src/items/module.rs line 291 at r4 (raw file):

impl HasFeatureKind for ModuleItemInfo {
    fn feature_kind(&self) -> FeatureKind {
        self.feature_kind.clone()

if requires a clone - possibly just return a & instead.

Code quote:

        self.feature_kind.clone()

[dean-starkware]

Reviewable status: 7 of 9 files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware and @orizi)

---

crates/cairo-lang-semantic/src/items/module.rs line 291 at r4 (raw file):

Previously, orizi wrote…

if requires a clone - possibly just return a & instead.

Done.

[orizi]

Reviewed 3 of 4 files at r5, all commit messages.
Reviewable status: 8 of 10 files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware)

---

crates/cairo-lang-semantic/src/resolve/mod.rs line 1749 at r5 (raw file):

    /// configuration. If the item uses an unstable, deprecated, or internal feature
    /// that is not permitted, a corresponding diagnostic error is reported.
    pub fn validate_item_usability<T: HasFeatureKind>(

This is the wrong name now - it only checks features

[dean-starkware]

Reviewable status: 8 of 10 files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware and @orizi)

---

crates/cairo-lang-semantic/src/resolve/mod.rs line 1749 at r5 (raw file):

Previously, orizi wrote…

This is the wrong name now - it only checks features

Done.

[orizi]

Reviewed 1 of 4 files at r5, 2 of 2 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)

[gilbens-starkware]

Reviewed 2 of 3 files at r3, 3 of 4 files at r5, 1 of 2 files at r6, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @orizi)

---

crates/cairo-lang-semantic/src/resolve/mod.rs line 851 at r6 (raw file):

                };
                if let Ok(trait_definition_data) =
                    self.db.priv_trait_definition_data(concrete_trait_id.trait_id(self.db))

Don't call directly to the priv_trait_definition_data, add another query trait_item_info_by_name query.

Code quote:

self.db.priv_trait_definition_data

[dean-starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware and @orizi)

---

crates/cairo-lang-semantic/src/resolve/mod.rs line 851 at r6 (raw file):

Previously, gilbens-starkware (Gil Ben-Shachar) wrote…

Don't call directly to the priv_trait_definition_data, add another query trait_item_info_by_name query.

Done.

[orizi]

Reviewed 3 of 3 files at r7, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware)

[orizi]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware)

[gilbens-starkware]

Reviewed 2 of 7 files at r4, 1 of 4 files at r5, 3 of 3 files at r7, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)

[orizi]

Reviewed 4 of 4 files at r8, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)

[orizi]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)