Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move standard to gemspec #21

Conversation

okuramasafumi
Copy link
Contributor

When we want to use standard-rails we need standardrb command, which comes from standard gem.
Although we can install these two gems separately, it seems natural that standard-rails has standard as a dependency.

When we want to use `standard-rails` we need `standardrb` command,
which comes from `standard` gem.
Although we can install these two gems separately, it seems natural
that `standard-rails` has `standard` as a dependency.
@searls
Copy link
Contributor

searls commented Dec 10, 2023

I understand your perspective, but I was careful to design lint_roller so that standard plugins would not need to depend on standard itself (the CLI). My hope is that RuboCop will consider adopting lint_roller as the plugin API (similar to railties) so that rubocop can depend on the same plugins standard does (any thoughts on this, @koic?). Another reason to avoid a direct dependency is to avoid pinning these rulesets to specific versions of Standard or RuboCop (instead, only to the provider of the cop implementations themselves).

I understand this requires listing two gems in a Gemfile, but my intent is similar to how one would list "rails" and, say, money-rails

@searls searls closed this Dec 10, 2023
@koic
Copy link

koic commented Dec 10, 2023

Yeah, I agree with @searls. I'm considering the adoption of the lint_roller plugin into RuboCop, in the future.

@okuramasafumi okuramasafumi deleted the move-standard-to-dependencies branch December 10, 2023 15:16
@okuramasafumi
Copy link
Contributor Author

I understand, thank you for the quick response!

@okuramasafumi
Copy link
Contributor Author

@searls Should we add standard to installation section? I'm not sure but I guess some people will need to install standard with standard-rails eventually.

@searls
Copy link
Contributor

searls commented Dec 12, 2023

Great point! Sorry the documentation on this repo is so bad. I clearly never revisited it after implementing it all. I made it a little clearer how to get set up in this commit 60225e7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants