Merge Upstream 23.01.2025

[ss220app]

This pull request merges upstream/master. Resolve possible conflicts manually and make sure all the changes are applied correctly.

Note

Requires Wiki Update:
www.github.com/ParadiseSS13/Paradise/pull/28030

Changelog

🆑 ParadiseSS13
tweak: Метеоры теперь появляются на краю карты (за пределами зоны строительства), вместо того чтобы быть настолько близко, что могут обходить спутники-щиты.
tweak: Емагнутые спутники-щиты теперь умнее и сбивают симулированные метеоры.
fix: Спутники-щиты, находящиеся в ящике, теперь сообщают местоположение ящика на карте управления, вместо угла карты.
tweak: Увеличена длина отображения flavor text при осмотре персонажей.
tweak: Повышена стоимость Mantis Blades в меню предателя (Traitor Uplink).
tweak: Снижена сила удара у Mantis Blades Синдиката и Нанотрейзен.
tweak: Удалены Mantis Blades из меню ядерного оперативника (Nuclear Uplink).
tweak: Предотвращено появление Mantis Blades в Syndicate Surplus Crate.
tweak: Mantis Blades больше не могут быть выбраны со скидкой.
add: Администраторы теперь могут легко создавать случайных персонажей для событий из числа экипажа с помощью Create Antagonist.
add: Добавлено дополнительное освещение в примерочной базы Синдиката в космосе.
fix: Внешнее освещение на базе Синдиката в космосе теперь подключено к АПЦ.
fix: Космическая база Синдиката теперь имеет вариант игрового автомата Claw Game, который не требует кредитов или аккаунта.
fix: Зависшие эффекты огня и ветра теперь действительно устранены.
fix: Режим строительства атмосферы (buildmode atmos) больше не будет иногда некорректно указывать параметры воздуха.
fix: Другие изменения атмосферы, которые ранее иногда могли не работать, теперь исправлены.
fix: Спрей больше не открывает два меню одновременно.
fix: Команда aheal больше не вызывает паузы на сервере.
tweak: Увеличена защита от радиации в MODsuit для парамедиков.
del: Удалены некоторые старые галлюцинации, подробности можно найти в PR.
tweak: Обновлены названия и описания, связанные с блюспейсом.
tweak: Обновлено множество лоровых описаний брони.
add: Зловещая активность Синдиката ощущается по всему сектору! Теперь почти все руины в космосе содержат некоторое количество экипировки, ранее доступной только в депо. Депо больше не гарантируется в каждом раунде, так что тщательно исследуйте все руины, чтобы найти добычу Синдиката.
/:cl:

Summary by Sourcery

Update movement to use movement loops.

New Features:

• Implement movement loops to manage timed movement.
• Add new movement procs to the move_manager datum.
• Add new signals for movement events.

Tests:

• Update tests to account for new movement system.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request refactors the movement and space drift systems, updates meteor and space debris spawning logic, enhances admin tools for event character creation, revises syndicate loot distribution, and fixes various bugs. Key changes include the introduction of new movement loop datums, improved spawning logic for meteors, enhanced admin capabilities for creating event characters, and adjustments to syndicate loot availability.

Sequence diagram for the new movement system

sequenceDiagram
    participant Client
    participant Move
    participant MoveLoop
    participant GLOB.move_manager

    Client->>Move: Move(new_loc, direct)
    Move->>Move: Check pre-move conditions
    Move->>GLOB.move_manager: Process movement
    GLOB.move_manager->>MoveLoop: Create movement loop
    MoveLoop->>Move: Execute movement
    Move-->>Client: Return movement result

Loading

Class diagram for updated movement components

classDiagram
    class MoveLoop {
        +direction: int
        +delay: int
        +lifetime: int
        +process()
        +stop()
    }

    class MovableAtom {
        +glide_size: int
        +Move()
        +Process_Spacemove()
        +newtonian_move()
    }

    class JetpackComponent {
        +stabilize: bool
        +configure_jetpack()
        +allow_thrust()
    }

    MovableAtom --> MoveLoop
    MovableAtom --> JetpackComponent

Loading

Flow diagram for meteor spawning logic

graph TD
    A[Start Spawn] --> B{Check Edge Location}
    B -->|Valid| C[Create Meteor]
    B -->|Invalid| D[Try New Location]
    C --> E[Set Trajectory]
    E --> F[Initialize Movement]
    F --> G[Start Movement Loop]
    D --> B

Loading

File-Level Changes

Change	Details	Files
Refactored movement and space drift systems to improve performance and maintainability.	Introduced new movement loop datums to handle various movement types. Replaced old movement functions like walk() with new movement loop systems. Implemented a new subsystem for handling space drift, separating it from general movement. Added new components for handling jetpack and drift mechanics.	code/controllers/subsystem/movement/movement_types.dm code/controllers/subsystem/movement/SSmovement.dm code/controllers/subsystem/movement/SSspacedrift.dm code/datums/move_manager.dm code/datums/components/drift.dm code/datums/components/jetpack_component.dm
Updated meteor and space debris spawning logic to improve game balance and performance.	Changed meteor spawning to occur at the edge of the map instead of near shield satellites. Improved logic for space debris movement and interaction with the environment.	code/game/objects/effects/meteors.dm code/modules/events/dust.dm code/modules/events/immovable_rod.dm
Enhanced admin tools and event character creation capabilities.	Added functionality for admins to create event characters randomly from the crew. Improved one-click antagonist creation with new options for event characters.	code/modules/admin/verbs/one_click_antag.dm code/modules/admin/topic.dm
Revised syndicate loot and space ruin loot distribution.	Removed Mantis Blades from Nuclear Uplink and adjusted their availability in other contexts. Reorganized syndicate loot spawners and added new loot pools for space ruins.	code/datums/uplink_items/uplink_general.dm code/game/objects/effects/spawners/random/pool/space_loot.dm code/game/objects/effects/spawners/random/traders/trader_department_spawners.dm
Fixed various bugs and improved game mechanics.	Fixed issues with shield satellites reporting incorrect positions. Resolved problems with stuck fire and wind effects. Improved buildmode atmos functionality to correctly set air parameters.	code/modules/station_goals/shield.dm code/controllers/subsystem/SSair.dm code/modules/mob/mob_movement.dm

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

We have skipped reviewing this pull request. It seems to have been created by a bot (hey, ss220app[bot]!). We assume it knows what it's doing!

[m-dzianishchyts]

!build_rust