Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Both Ears Cigs #1759

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

NanimeDesu
Copy link

@NanimeDesu NanimeDesu commented Jan 23, 2025

Что этот PR делает

Даёт возможность хранить сигарету за ухом.

Почему это хорошо для игры

Удобство, теперь можно хранить сигарету за ухом.

Тестирование

Локалка, сигареты можно было класть за ухо. При компиле ошибок нет (Первый ПР не судите строго)

Changelog

🆑

tweak: Добавил возможность класть сигареты в слот ушей

/:cl:

Summary by Sourcery

New Features:

  • Cigarettes can now be placed in both ears.

Copy link

sourcery-ai bot commented Jan 23, 2025

Reviewer's Guide by Sourcery

This pull request introduces the ability to store cigarettes in the ear slots.

Class diagram showing updated cigarette item slot flags

classDiagram
    class CigaretteItem {
        +icon_state: string
        +item_state: string
        +throw_speed: float
        +slot_flags: ITEM_SLOT_MASK | ITEM_SLOT_BOTH_EARS
        +w_class: WEIGHT_CLASS_TINY
        +body_parts_covered: null
        +attack_verb: null
    }
    note for CigaretteItem "Added ITEM_SLOT_BOTH_EARS flag
to allow cigarettes to be
stored behind ears"
Loading

File-Level Changes

Change Details Files
Added the ability to store cigarettes in the ear slots.
  • Modified the slot_flags to include ITEM_SLOT_BOTH_EARS.
code/game/objects/items/weapons/cigs.dm

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the :finnadie: НЕ МОДУЛЬНО Ну это ваще пиздец. Либо засовывай в модуль, либо заливай на апстрим. label Jan 23, 2025
@ss220app ss220app bot added the 📜 CL валиден Этот чейнджлог будет успешно опубликован label Jan 23, 2025
@Furrior
Copy link

Furrior commented Jan 23, 2025

Снова? Иди проверяй, чтоб ухом курить нельзя было

@NanimeDesu
Copy link
Author

Снова? Иди проверяй, чтоб ухом курить нельзя было

проверил, в куклу реагенты не вводились

@NanimeDesu
Copy link
Author

Снова? Иди проверяй, чтоб ухом курить нельзя было

А я понял что имелось в виду, курить да, можно, но реагенты не поступают, исправим

@Furrior
Copy link

Furrior commented Jan 23, 2025

Сделай присвоение флага модульно или на оффы тогда. По приколу можешь еще сделать, чтоб заженная сигарета за ухом дамажила, если хочешь

Copy link

github-actions bot commented Feb 7, 2025

This pull request seems to be stale as there have been no changes in 14 days, please make changes within 7 days or the PR will be closed. If you believe this is a mistake, please inform a development team member on Discord.

@github-actions github-actions bot added the Stale ПР долго был не активен, и требует обновления. label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:finnadie: НЕ МОДУЛЬНО Ну это ваще пиздец. Либо засовывай в модуль, либо заливай на апстрим. 📜 CL валиден Этот чейнджлог будет успешно опубликован Stale ПР долго был не активен, и требует обновления.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants