Translate Upstream Merge 30.01.2025 #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## About The Pull Request Fixes the fact that the justice mech dash could only be performed in eight main directions, which was clearly not intended, since you made a dash at the completely wrong place and not at the target. ## Why It's Good For The Game Fixes ability's weird behavior ## Changelog :cl: fix: Fixed Justice mech's dash ability /:cl:
## About The Pull Request  Fish trophies from persistence are meant to be dusted and thus drop no fillet. So we always need to be checking that we actually have a `fillet_type` before attempting to create one. Just fixes one spot that wasn't doing that. ## Why It's Good For The Game Annoying CI failures for no reason begone. ## Changelog :cl: fix: due to a number of complaints of fish explosions, chrystarfish will no longer be chosen as the random starting fish for the fish mount. /:cl:
Fixes a very large number of typos. A few of these fixes also extend to variable names, but only the really egregious ones like "concious".
…ion#89227) ## About The Pull Request Closes tgstation#89206 ## Changelog :cl: fix: Fixed crafting menu not changing the cursor when hovered over /:cl:
## About The Pull Request  Tin. These were hanging refs to the copied object ## Changelog N/A --------- Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
## About The Pull Request https://github.com/user-attachments/assets/a57e9bd2-8e00-4ab4-86de-9facba477955   Resprites medbots and related sprites - stacked mediborg skin, assemblies ## Why It's Good For The Game Consistent with the new medkits ## Changelog :cl: image: New medbot sprites image: New stacked medibot borg skin sprite /:cl:
## About The Pull Request Fishing UI has received a major glowup: https://github.com/user-attachments/assets/e255822c-9c2c-4e09-843d-20ea70f470f5 All fishing rods now have unique frames (with material rods' frames' colors being based on their material), and most fishing sources now have unique backgrounds. Completion bar now uses alpha filters, making it much smoother, and bait bar is assembled from thin lines, which allows us to avoid stretching it when we need to resize the bar. Fixed experiments not unlinking after being completed, resulting in infinitely stacking examine lines on advanced fishing rods. Fish death messages now use more fitting span_warning. Removed devious SS_POST_FIRE_TIMING from the fishing SS, as it made sometimes the fishing SS only fire every ***two*** ticks instead of every tick, despite passing 0.05s (1 tick) into its process() calls - this flag only makes sense on heavy and costly subsystems, not on a subsystem dedicated mostly to fishing minigames. This is required as now instead of directly assigning coordinates (why???) fishing UI uses animate() to control the bait bar and fish icons, making it much smoother. Also gave blue dough its own bait overlay and mansus rift its own portal icon because why not. ## Why It's Good For The Game Fishing UI didn't look very nice, and removing the subsystem flag makes the game smoother. ## Changelog :cl: qol: Fishing minigame should be smoother now fix: Fixed infinitely stacking examine lines on advanced fishing rods image: Resprited fishing UI image: Blue doughballs now have their own fishing rod overlay image: Resprited mansus rift fishing portal overlay /:cl:
## About The Pull Request x = x is silly ## Why It's Good For The Game fix ## Changelog :cl: fix: PDA ringtones can be changed in-game /:cl:
## About The Pull Request - Fixes tgstation#89242 - Fixes balloon alert runtime when the assembly is secured & the holder cannot be attached ## Changelog :cl: fix: fixes balloon alert runtimes with assembly holder /:cl:
…on#89253) ## About The Pull Request This sets the processing subsystem for `/datum/status_effect/fire_handler` to use `STATUS_EFFECT_PRIORITY` (`SSpriority_effects`) ## Why It's Good For The Game I'd say being on fire is classified under "certain status effects that'd fuck the player over from lasting much longer due to server load" ## Changelog :cl: fix: Being on fire or wet should no longer last much longer than intended while the server is under load. /:cl:
## About The Pull Request Commit messages should be descriptive of all changes. The "incorrect `\The` macro capitalization" was intentional when it was added, but as far as I know TG says "the supermatter" rather than "The Supermatter," so it's incorrect now. This is completely untested. I don't even know how you'd go about testing this, it's just a fuckton of strings. Someday I want to extract them and run NLP on it to catch grammar problems... ## Why It's Good For The Game Basic grammar pass for name strings. Should make `\the` work better and avoid cases like `the John Smith`.
## About The Pull Request   ## Changelog :cl: fix: fixed timestamps being timezone sensitive admin: due to this bug some logs may have been timestamped incorrectly /:cl: Co-authored-by: TiviPlus <572233640+TiviPlus@users.noreply.com>
## About The Pull Request Wiki is currently down but this should work once it's back. If you're on 516 or above it will open the page in-game, if you're still on 515 then it'll do the old behavior from the PR linked in the why it's good for the game section. ## Why It's Good For The Game In tgstation#86891 this was removed "Until 516 with webview2 releases", well it's here now so we're fvckin back ## Changelog :cl: qol: The wiki books for users on 516 no longer opens the page on an external website on your browser. /:cl:
No player facing changes, simply fixes an error during the hsl conversion which led to sass warnings as the % was missing.
## About The Pull Request - Fixes tgstation#89263 - Fixes tgstation#89262 A mob's `stat` integer value increases the more messed up they become https://github.com/tgstation/tgstation/blob/5ec828cc4dfa83549afd6504dc9300d6dcdd190e/code/__DEFINES/stat.dm#L6-L10 So when our `minimum_process_stat` is actually the 2nd highest integer value there is https://github.com/tgstation/tgstation/blob/5ec828cc4dfa83549afd6504dc9300d6dcdd190e/code/datums/quirks/_quirk.dm#L38 The quirk never processes because we aren't dead yet i.e our stat is below hard crit for a majority of normal game play.  So let's reverse our thinking. ## Changelog :cl: fix: quirks work again /:cl:
## About The Pull Request Fixes NovaSector/NovaSector#4798 Fixes tgstation#87974 Fixes the race condition that lead to both of the above. Basically what is going on with this, is a second hotspot can potentially be created (through say, `fire_act()` of a fuel pool). This causes `set_active_hotspot()` to be called before the first one is finished initializing, which results in the first hot spot becoming qdeleted midway through its initialization and causing issues. <details><summary>More in-depth explanation</summary> Hotspot A gets initialized->perform_exposure() is called -> turf's `active_hotspot` is set to hotspot A -> fire_act() creates a second hotspot-Hotspot B Hotspot B gets initialized now and goes through the same process above, notably qdeleting the previous `active_hotspot`, which is Hotspot A. Then we return to Hotspot A's `initialize()` where it's now been qdeleted, causing all of these issues. </details> Should be fixed now that this special case has been considered. ## Why It's Good For The Game Less spurious CI failures ## Changelog Nothing player facing
## About The Pull Request Made mouse corpse working for this ritual, just like corpses of any other mob. ## Why It's Good For The Game I consider this as a bug, since mouse corpse is a food subtype despite being a mob corpse. ## Changelog :cl: fix: mouse corpse can be used to summon codex citatrix /:cl:
…station#89136) ## About The Pull Request ### _**HEY HUSTLERS**_ Do you want to know all about the station's real GDP **_BREADWINNERS_** this shift? Well, look no further than the all new GMM SPOTLIGHT. On select shifts (Where the trait is rolled), the GMM SPOTLIGHT will shine on who's HUSTLING and GRINDING the hardest so YOU CAN ~~know who has enough money to try and mug them~~ LEARN THE SECRETS OF THE CREDIT WHISPERS **AMONG US**. Don't know where these legendary GRIND-O-HOLICS are this very SECOND? Well, the GMM will UPDATE the SPOTLIGHT every 5 minutes, with their IDENTITY MADE KNOWN to all crewmates via the station updates and economic summary newcaster channels. WHAT ARE YOU WAITING FOR? ALIEN JIM KRAMER??? UNLEASH THE SECRETS OF THE HUSTLERS **TODAY**!!! (The original idea for this station trait was given to me by xhorian/@YesterdaysPromise a few months back, so big thanks to him for the inspiration.) Video of it in action: https://discord.com/channels/326822144233439242/326831214667235328/1330408517248614432 ## Why It's Good For The Game This is, obviously, a negative station trait. On shifts where players are working to make lots of personal profit, it can either serve as a badge of honor, or as a target being painted on your back about who has the most money. Still, it's somewhat flavorful, and I think it could be interesting to have happen to a player, where suddenly a beam of light from above ™️ suddenly appears and starts following you. I wouldn't be against giving command some kind of control to let them cancel the effect early by un-subscribing from their newsletter, but it depends on how people feel about this. ## Changelog 🆑 add: Stations in your sector may start with the GMM spotlight, a massive economic broadcast spotlight that will follow the wealthiest crewmate on board until the next paycheck /🆑
…station#88716) ## About The Pull Request Where I forget about a pr for 5 months. This started because there was a pr that made it so skills transfer between the real and the digital, and so I thought it'd be really funny if I could train boxing in virtual reality... but there's no easy way to get boxing gloves or anything like it in the virtual world... So! I decided to make a disk for it, but then thought about fishing and gaming and- Anyhow it all went downhill from there and here we are now: Gimmick Disks. (And a refactor of disk loading) This implements a new type of bitrunning disk that instead of a single item or ability, grants a full set of thematic items/abilities! Unhelpfully cosplay as a wizard! Game inside your game! Down a digital protein shake and box some simplemobs! As the name "Gimmick" implies, these are primarily intended to help shake up the sometimes stale bitrunner gameplay. By letting you invoke, if you so desire, what to me is the most enjoyable gaming experience: doing stupid shit with your buddies. To facilitate the new type of disk I had to refactor disk loading, as it was hardcoded to the item types. Instead, we make disk loading send a signal to the bitrunner, and register for this when held in their inventory. This allows us to do things like making the lead acid battery give you shock touch when held, without needing to make an explicit typecheck or iterate over every item in the bitrunner's nested contents to see if they have a loadable item. ## Why It's Good For The Game I think it'd be really funny if you could train your boxing in the digital realm. As said above, I feel the bitrunner gameplay can get stale sometimes, and this is how I hope to help people shake it up for themselves sometimes. By giving them more stupid shit to do. Doing stupid extended bits with other people is one of the things I enjoy most out of ss13, and this is there to let the bitrunners do exactly that with each other. And sometimes you just have to roleplay as Gamers:tm: entering virtual reality to fight the virtual syndicate in bad cosplay while roleplaying as a wizard smoking his magic weed, an overly edgy rogue, and the healer desperately trying to keep them from exploding into a million pieces. ## Changelog :cl: refactor: Bitrunning item/ability loading has been refactored. Please report any issues. add: Added Bitrunning gimmick loadout disks. These disks contain full sets of equipment for all your digital cosplay needs, each including questionably helpful equipment. Currently includes Sports (Boxer, Skater, Archer, Fisher, Gamer) and Dungeon Crawling (Alchemist, Rogue, Healer, Wizard). add: Taking a lead acid battery into the netpod with you now gives your bit avatar shock touch. /:cl:
## About The Pull Request Bandaid fix of broken shadows on 516. Renamed refresh button to rebuild for consistency in plane debugger (Edit/Dubug-Planes). Rebuild now also reapplies parallax, so it will not be turned off after rebuild. Closes tgstation#89230 ## Why It's Good For The Game faster 516 adoption ## Changelog :cl: fix: fixed shadows on 516 /:cl:
## About The Pull Request  ## Changelog :cl: fix: Fixed a missing area in the corner of icebox morgue /:cl:
…9225) ## About The Pull Request Closes tgstation#88878 by reverting window painting to old behavior ## Changelog :cl: fix: Fixed issues with window tinting/coloration /:cl:
…#89278) ## About The Pull Request does what it says on the title. Adds ignored faction to pellet cloud component, allowing shotguns to make use of the ignore faction variable for goofy things like shotgun magic, funny TDM rounds, or turrets Honestly more for downstream effort. ## Why It's Good For The Game 1. I dont see too much on why not. 2. Its a variable that gets used very rarely, and when used is preferable that it works. 3. pellet cloud is already capable of, funnily enough, handling homing if you set up a shotgun shell to set_homing_target in the way the Abielle smartgun bullets are. (though, it ends up becoming a wad of pellets instead of some fancy fan that coalesces into the target) ## Changelog :cl: fix: adds Ignored Factions to pellet cloud component variable transfer /:cl:
…tion#89279) ## About The Pull Request Fixes NovaSector/NovaSector#4826 Since tgstation#88651 PAIs have been blanket barred from being able to pass any `can_perform_action()` check. From the pr:  ## Why It's Good For The Game As it turns out there are a few things that it makes sense for them to be able to interact with. Now you can again! ## Changelog :cl: fix: fixed PAIs not being able to send or reply to messages using their digital messenger app. fix: fixed PAIs not being able to turn off the GPS tracking using their gpa app. /:cl:
## About The Pull Request Follow up on tgstation#89070. While testing yes it did work however it would only increase the temps by 1K every tick because the heating coefficient was very low(0.02). It's now set to 1 so the temps can rise from anywhere in the range of 2K to 10K per tick now. ## Changelog :cl: fix: Herignis has a decent heating effect on mobs reagents /:cl:
github-actions
bot
added
Документация
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
💾 Изменение конфига
Ф-ф-фуриор...?
Документация
Некоторые просто любят писать тонну текста, которую никто не будет читать.
🖌️ Спрайты
Вы заработали свою миска-рис и кошко-жена. Партия гордится вами!
📝 Перевод
Фаргус® Полностью на русском языке
TGUI
Добавление или изменение существующего интерфейса на базе фреймворка TGUI
🗺️ Изменение Карты
В этом ПРе затронут файл не станционной карты. Может и не один.
Документация
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Что этот PR делает
Коммиты и фикс перевода с апстрима