forked from tgstation/tgstation
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog Generation | BandaStation #1012
Merged
Gaxeer
merged 5 commits into
ss220club:master
from
m-dzianishchyts:changelog-generation-tweak
Jan 18, 2025
Merged
Changelog Generation | BandaStation #1012
Gaxeer
merged 5 commits into
ss220club:master
from
m-dzianishchyts:changelog-generation-tweak
Jan 18, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request modifies the changelog system to store changelogs in a subdirectory, and customizes the changelog window. Class diagram for the changelog system changesclassDiagram
class ChangelogBandaStation {
-data: string
-selectedDate: string
-selectedIndex: number
-dateChoices: array
+constructor()
+setData(data)
+setSelectedDate(date)
+setSelectedIndex(index)
+getData(date, attemptNumber)
+componentDidMount()
+render()
}
class changelog {
+ui_interact(user, ui)
+ui_static_data()
}
class changelog_item {
+New(date)
-item_filename: string
}
changelog --> ChangelogBandaStation: uses
changelog_item --> ChangelogBandaStation: provides data
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![:shipit: :shipit:](https://github.githubassets.com/images/icons/emoji/shipit.png)
Gaxeer
requested changes
Jan 18, 2025
Co-authored-by: Gaxeer <44334376+Gaxeer@users.noreply.github.com>
Gaxeer
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🎸 Инструменты
Мы выдаем себя за реальное сообщество разработчиков.
📜 CL не требуется
Эти изменения не влияют на игровой процесс или игроки по какой-то причине не должны о них знать
Улучшение
Мы сделали что-то немного лучше, на наш взгляд.
TGUI
Добавление или изменение существующего интерфейса на базе фреймворка TGUI
![:shipit: :shipit:](https://github.githubassets.com/images/icons/emoji/shipit.png)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Что этот PR делает
Изменяет пути к чейнджлогам в системе ТГ. Кастомизирует окно чейнджлога.
По результатам бурного обсуждения в дисе стало ясно, что у системы чейнджлога есть 2 основные проблемы:
Проблема 1 решается этим ПРом, поскольку чейнджлог лежит в поддиректории.
Проблема 2 может решиться наличием отдельной ветки и ленивыми HTTP запросами, но она мне не кажется существенной, особенно с учетом того, что коммиты ТГ уже переносятся в наш мастер
как-есть
и чейнджлог коммиты все равно останутся.Тестирование
m-dzianishchyts@b15f7eb
m-dzianishchyts@9b6bb0b
Картинко
Summary by Sourcery
Update changelog paths and customize the changelog window.
New Features:
Build:
CI: