Remove screenshot compare test

ss220club · Jan 22, 2025 · b7dafe8 · b7dafe8
1 parent 6926460
commit b7dafe8
Showing 1 changed file with 0 additions and 38 deletions.
diff --git a/.github/workflows/ci_suite.yml b/.github/workflows/ci_suite.yml
@@ -235,44 +235,6 @@ jobs:
       minor: ${{ matrix.setup.minor }}
       max_required_byond_client: ${{ matrix.setup.max_client_version || needs.collect_data.outputs.max_required_byond_client }}
 
-  compare_screenshots:
-    if: needs.collect_data.outputs.alternate_tests == '[]' || needs.run_alternate_tests.result == 'success'
-    needs: [ collect_data, run_all_tests, run_alternate_tests ]
-    name: Compare Screenshot Tests
-    timeout-minutes: 15
-    runs-on: ubuntu-22.04
-    steps:
-      - uses: actions/checkout@v4
-      - name: Setup directory
-        run: mkdir -p artifacts
-      # If we ever add more artifacts, this is going to break, but it'll be obvious.
-      - name: Download screenshot tests
-        uses: actions/download-artifact@v4
-        with:
-          path: artifacts
-      - name: ls -R
-        run: ls -R artifacts
-      - name: Setup screenshot comparison
-        run: npm i
-        working-directory: tools/screenshot-test-comparison
-      - name: Run screenshot comparison
-        run: node tools/screenshot-test-comparison/index.js artifacts code/modules/unit_tests/screenshots artifacts/screenshot_comparisons
-      # workflow_run does not give you the PR it ran on,
-      # even through the thing literally named "matching pull requests".
-      # However, in GraphQL, you can check if the check suite was ran
-      # by a specific PR, so trusting the (user controlled) action here is okay,
-      # as long as we check it later in show_screenshot_test_results
-      - name: Save PR ID
-        if: failure() && github.event.pull_request
-        run: |
-          echo ${{ github.event.pull_request.number }} > artifacts/screenshot_comparisons/pull_request_number.txt
-      - name: Upload bad screenshots
-        if: failure()
-        uses: actions/upload-artifact@v4
-        with:
-          name: bad-screenshots
-          path: artifacts/screenshot_comparisons
-
   test_windows:
     name: Windows Build
     needs: [collect_data]