Fix Handling of UUID and Other ID Formats in PgVectorStore #2111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the I would appreciate your feedback. @ilayaperumalg |
jitokim
force-pushed
the
GH-1856-fix-pgvector-id-column
branch
from
0d8e5fc to
e518d30
Compare
- Add handling for UUID, TEXT, INTEGER, SERIAL, BIGSERIAL formats in `convertIdToPgType` function. - Implemented type conversion logic based on the IdType value (UUID, TEXT, INTEGER, SERIAL, BIGSERIAL). - Add unit tests to validate correct conversion for UUID and non-UUID IdType formats. - `testToPgTypeWithUuidIdType`: Validates UUID handling. - `testToPgTypeWithNonUuidIdType`: Validates handling for non-UUID IdTypes. Signed-off-by: jitokim <pigberger70@gmail.com>
jitokim
force-pushed
the
GH-1856-fix-pgvector-id-column
branch
from
e518d30 to
751778e
Compare
|
How about PgVectorStore supporting only the UUID type? |
|
@ilayaperumalg Thanks for review 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2014 .
Refactor ID handling for different IdType formats
convertIdToPgTypefunction.testToPgTypeWithUuidIdType: Validates UUID handling.testToPgTypeWithNonUuidIdType: Validates handling for non-UUID IdTypes.