Enables UISegmentedControl touch #283
Conversation
There was a problem hiding this comment.
A small code style issue that should be fixed.
But I’m also wondering if we shouldn’t just change the UIButton check to a more generic UIControl check. Since any, even custom, controls would then work automatically. Which might be desired. Would like your (@mumme) and CA’s input @mhallendal @cerihughes on it though.
| @@ -432,6 +432,11 @@ - (BOOL)gestureRecognizer:(UIGestureRecognizer *)gestureRecognizer shouldReceive | |||
| UIView *currentView = touch.view; | |||
|
|
|||
| while (currentView != nil && currentView != self.view) { | |||
|
|
|||
There was a problem hiding this comment.
🎨 Remove the empty line
| @@ -432,6 +432,11 @@ - (BOOL)gestureRecognizer:(UIGestureRecognizer *)gestureRecognizer shouldReceive | |||
| UIView *currentView = touch.view; | |||
|
|
|||
| while (currentView != nil && currentView != self.view) { | |||
|
|
|||
| if ([currentView isKindOfClass:[UISegmentedControl class]]) { | |||
There was a problem hiding this comment.
Wondering if we should not add this check and instead change the UIButton check to UIControl?
@mhallendal @cerihughes What do you and CA think?
Generated by 🚫 danger |
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
==========================================
- Coverage 93.48% 93.41% -0.08%
==========================================
Files 72 72
Lines 5051 5055 +4
==========================================
Hits 4722 4722
- Misses 329 333 +4
Continue to review full report at Codecov.
|
|
I was intrigued by the fact that we were traversing the view hierarchy looking for specific subclasses and created an alternative PR - #285 |
|
I’d be in favour of merging this (after changing to look for
|
|
@mhallendal @marmelroy @mumme What do you think of this ☝️ |
@rastersize