support SLIP-19 ownership proofs, for trezor-based Standard_Wallets

[SomberNight]

• wallet/keystore: add generic APIs re add_slip_19_ownership_proofs_to_tx
• transaction.py: add slip_19_ownership_proof field to PartialTxInput
  • though the respective PSBT field is not yet merged upstream... :/
    • bips PR: BIP-174: add SLIP-0019 fields bitcoin/bips#1434
• trezor:
  • if (generic) proof present, we can pass it to a Trezor signer
  • specifically for singlesig wallets with a Trezor keystore, actually implement ~creating the proofs
• qt tx_dialog:
  • add option to export tx including the proofs

---

• this allows trezor-based wallets to sign transactions with unsigned external inputs

  • this allows doing e.g. coinjoins
  • previously we only supported signed external inputs (Support external pre-signed inputs on Trezor #8324)
    • this restricted the trezor-based wallet to sign last (and precluded there being multiple trezor-based wallets involved)

• closes SLIP-19 ownership proofs #8325

  • that issue can be considered more generic, e.g. "what about multisig inputs?", "what about Software_KeyStores?" -- if someone wants to, they can open new issues with such narrower scopes.

[SomberNight]

@ecdsa see the second commit "qt tx_dialog: share btn: replace nested menus with checkboxes"

[ecdsa]

looks good to me. I think a popup would not be better.

update: maybe it would be better to show the checkboxes at the top of the menu, because these are options on which the latter menu items depend.

[hynek-jina]

Why is the option to include ownership proofs disabled?

[SomberNight]

Why is the option to include ownership proofs disabled?

It is only enabled for "singlesig wallets with a Trezor keystore" for now. The picture above is for a software keystore.
The actual creation and validation of proofs is not implemented here, we are just asking for proofs from the trezor, and when present, passing them to a trezor. For a software keystore to be able to include proofs, we would need code to create the proofs. The API added here is extensible to do that but is not done for now.

maybe it would be better to show the checkboxes at the top of the menu, because these are options on which the latter menu items depend.

Another view though is that the options are rather niche, most people don't need them for most cases, and so it makes sense to make the often-used-buttons easier to spot and click.

[hynek-jina]

I'm trying to test it, but I'm getting an error RuntimeError('ProcessError: Unverifiable external input.')

Steps

• Wallet 1 [W1] creates transaction
• In preview click on Include SLIP-19 ownership proofs
• W2 creates second transaction
• W2 imports transaction made by W1
• W2 signs the transaction - confirming - (all outputs, locktime, my share in payment) - Btw. here I might not need to confirm change address from W1?
• Import signed back into W1 → does it attach correctly ownership proofs here?
• Sign the transaction → ⚠️ RuntimeError('ProcessError: Unverifiable external input.')

[SomberNight]

I am having trouble understanding the steps you took.

Here is an example of a manual coinjoin between two parties:

1. wallet1 creates unsigned tx1, paying itself (e.g. 1 input, 2 outputs)
2. in wallet1, go to tx Preview. Share>"Include SLIP-19 ownership proofs", then Share>"Copy to clipboard"
   • let's call the exported tx "psbt1"
3. wallet2 creates unsigned tx2, paying itself (e.g. 1 input, 2 outputs)
4. in wallet2, go to tx Preview. Combine>"Join inputs/outputs", paste psbt1.
   • now the tx preview dialog shows a new tx, "tx3", which has 2 inputs and 4 outputs
5. in wallet2 still, tx dialog, now you can click "Sign"
   • the inputs of tx3 that are owned by wallet2 will be signed now - trezor is willing to sign as all inputs either belong to wallet2 (itself) or have SLIP-19 ownership proofs showing they are external
6. in wallet2 still, tx dialog, click Share>"Copy to clipboard"
   • let's call the exported tx "psbt2"
7. in wallet1, menubar>Tools>"Load transaction">"From text". paste psbt2.
8. in wallet1, tx dialog, now you can click "Sign"
   • the inputs of tx3 that are owned by wallet1 will be signed now - trezor is willing to sign as all inputs either belong to wallet1 (itself) or are already signed
     (Ownership proofs are not needed at this point. They are only needed for inputs that are both unsigned and external.)
9. tx3 is now fully signed and you can broadcast it

[hynek-jina]

You description is better, but I see no difference.. The error comes in step 8

[SomberNight]

Hmm. Not sure. I wrote the above steps while following them and it worked.

In my case, both wallet1 and wallet2 use p2wpkh scripts, and one is a trezor safe3 and the other is a trezorT.
If you are testing not on mainnet, could you share psbt2?

[hynek-jina]

Sure.. Here:

cHNidP8BAPACAAAAAoCy57FMcBoCnrbrDXl0gQWYnGyPlFawxkX0dIi7uqeuEQAAAAD9////vxZTjc/7Vqlrv8fnug4ZQUt/tqhWN9LLQ0Q8JO/byL8AAAAAAP3///8EECcAAAAAAAAiUSAQdLBG3dfWhoPIbet17FLNJu7mCzwY9tPI6O1AnXIMyw1LAAAAAAAAFgAUy8GJOWxDDf3yUNXvXx9rw+CbwZogTgAAAAAAACJRIMoufoRJfLw4lOsZmIiCNNM4dIRIn5xegQkd+Xnklgy2zn4CAAAAAAAWABTOX6Nuj++WMXpBeaU6IHG/I2e5PZpaJwAAAQEfxpkAAAAAAAAWABTpvgEYAAGpX8JNBf6uzavB6gNOSgEA/RsTAQAAAAABHzHfRN5CX4+ORCSQw7ACpLGYFPeih/UUFVRyiag7uSxaBgAAAAD/////dIKjMx2p8IQmmfUQW4YnsfO1kMmXI2B8YhjtwwH3HLEGAAAAAP/////UidDUe3mM75saI1qjiM5O1aEqVFqCljiCMPnQ2cNmLQgAAAAA/////9DdMmwWbxu0J2tkC6tKBJn2tUeqpkS2ZrAR8msWfmSkAAAAAAD/////dIKjMx2p8IQmmfUQW4YnsfO1kMmXI2B8YhjtwwH3HLEQAAAAAP////8x30TeQl+PjkQkkMOwAqSxmBT3oof1FBVUcomoO7ksWg0AAAAA/////5dO/lS3i7D+wzvk68DTr7vNvxAAn3KdSYDFBwMt9Q6OBQAAAAD/////1InQ1Ht5jO+bGiNao4jOTtWhKlRagpY4gjD50NnDZi0XAAAAAP////8XXp7D+PmbBgKD3IbbRtZ/lWDa/31pDLpRTtNFOiR6RwcAAAAA/////yctWgC5MnkMt28ioQzhnCUIJZalleWV619SCaMn9THKAQAAAAD/////1InQ1Ht5jO+bGiNao4jOTtWhKlRagpY4gjD50NnDZi0cAAAAAP////+JCydekw5SvfRTEpMgEai5/Mva7MuAMerfdffH2j/MfgsAAAAA/////9vCHsW6vB5FrQpt+Q/+xHq0aTuiYJgmtieDS4trYKoZCgAAAAD/////dIKjMx2p8IQmmfUQW4YnsfO1kMmXI2B8YhjtwwH3HLEmAAAAAP////90gqMzHanwhCaZ9RBbhiex87WQyZcjYHxiGO3DAfccsSgAAAAA/////zHfRN5CX4+ORCSQw7ACpLGYFPeih/UUFVRyiag7uSxaGgAAAAD/////dIKjMx2p8IQmmfUQW4YnsfO1kMmXI2B8YhjtwwH3HLExAAAAAP////90gqMzHanwhCaZ9RBbhiex87WQyZcjYHxiGO3DAfccsToAAAAA/////3SCozMdqfCEJpn1EFuGJ7HztZDJlyNgfGIY7cMB9xyxPAAAAAD/////dIKjMx2p8IQmmfUQW4YnsfO1kMmXI2B8YhjtwwH3HLE9AAAAAP////90gqMzHanwhCaZ9RBbhiex87WQyZcjYHxiGO3DAfccsUUAAAAA//////86rdPXsTv0mpo5cVm+b/ooaCSkVuhd5So3nfZt7TPqEAAAAAD/////Md9E3kJfj45EJJDDsAKksZgU96KH9RQVVHKJqDu5LFooAAAAAP////90gqMzHanwhCaZ9RBbhiex87WQyZcjYHxiGO3DAfccsUwAAAAA/////5dO/lS3i7D+wzvk68DTr7vNvxAAn3KdSYDFBwMt9Q6OQwAAAAD/////0N0ybBZvG7Qna2QLq0oEmfa1R6qmRLZmsBHyaxZ+ZKQsAAAAAP/////UidDUe3mM75saI1qjiM5O1aEqVFqCljiCMPnQ2cNmLUcAAAAA/////xdensP4+ZsGAoPchttG1n+VYNr/fWkMulFO00U6JHpHIgAAAAD/////Md9E3kJfj45EJJDDsAKksZgU96KH9RQVVHKJqDu5LFouAAAAAP////99/T2csfVaYvzHL3zhXi4Fl6N2Z6FZpNMW2P4nzmc7HFcAAAAA/////4kLJ16TDlK99FMSkyARqLn8y9rsy4Ax6t9198faP8x+GwAAAAD/////IEBCDwAAAAAAFgAUWG1Q+W96J64Z8aNV/qVRK7E7xPZAQg8AAAAAABYAFHaWBqNs6jQyzER2lASYhNOupAvlQEIPAAAAAAAiUSBd1kmZ0G/eYnUG6Yd2mkdjgDAw7SOociEjwqoeDbMIgkANAwAAAAAAFgAU09XlGjHQ+jJrOf+c8l6oG/0crzBADQMAAAAAACJRIArdP2+XstJEJslbvcRm4zj+1Pfrb43DyrqeTspDzpxnQA0DAAAAAAAiUSAvMF6NsVtuCGkQu68fhR6QuwdCsNRKhYmPqqsQ6IuxfEANAwAAAAAAIlEgQKZI5C7trNS1M4X4FjodJOin6yW45nLgMPpAic+zGG9ADQMAAAAAACJRIHLqgJNGK1GWfp+TUjstIJQU1dXA38vsg1JGJfHJpVIiQA0DAAAAAAAiUSC5M8CJgrVzvYC9Gy894amOhy5IADjzwvdMz779LmNjiEANAwAAAAAAIlEg140uqsAxUJSo7lXJ67pqPbEQjpc6Vky95oS+0rSQGLdADQMAAAAAACJRINqAkTBOkAQM76V1+cu7wDKayeP8G5SCs/clbs8m2Idpaw8CAAAAAAAiUSBy5w0/j+EuigNYF4gImyuJw9AL9gu9n311H6aeqWFUlQAAAgAAAAAAIlEgFoVTzGQBbgxHrtagS7lTAqEBIKoNXxj+osH3jyoKGMgAAAIAAAAAACJRIHErcqsor5rm+ER42zNQpn/DU55d14Xdmzkft699bANKAAACAAAAAAAiUSCMofiND/0BsMASKIKMJepNaI8Y+JEmrgvwLM47QlSq2qnmAAAAAAAAFgAU27H8RU9fxDdnP/3EBjcfllIEwVqp5gAAAAAAACJRIAjBKquIaG8xhrow63kBrhuVlWx1YUTxQChvL9It0RUGxpkAAAAAAAAWABTpvgEYAAGpX8JNBf6uzavB6gNOSiBOAAAAAAAAIlEgBvGDwjIbdxs086BM36ijCpDA4sNzbXpYnHMc5HztymMgTgAAAAAAACJRICnP66sNZZ2vUV+W733mYmW41kZDSRRNjn1h0pZ4da+7IE4AAAAAAAAiUSA2EviaUQfn4hMb/mpnyZfo5PghdBV6fT3oKp3XxVfC4CBOAAAAAAAAIlEgQWnDcoCxlNmYGDRLaZMANqKj4Esssorv9BWEl6J1KcogTgAAAAAAACJRIEizXQ7dSZrdnISZiE5tG852NDZVynI2XCmGWDqoZA/yIE4AAAAAAAAiUSBedPwJ7ckZPQ2VnufaylRpolQoqzXXT6kAZaC1lFfsPiBOAAAAAAAAIlEgvMXXBeliJ8BljfZzj8d0KFOkuXS3/uefXtXE3Zi6CM0QJwAAAAAAACJRINFXWdeSCUp6wv/2pOtgM1iuhG4s7D7TxdzudEEjr2/DECcAAAAAAAAiUSDgMTEQ7uxCgDYHTO6iUwSz9AE3ESVAVuShgsztfAfPQBAnAAAAAAAAIlEg6jIDEOTsr4k3O6qb+6u86NWBmo8TrZ79aWKYe6ivNHUQJwAAAAAAACJRIPmyQeEWEE8hbpGRDmk9x8pBcRsQpfwRpzsbeQ9aUdwRACAAAAAAAAAiUSB2cZBhbNvflp9wKXfU7jcxevKeEVAVGyXUDLV/iYFaIwAgAAAAAAAAIlEgzYS/kiRjIteGuOOToVRydzFERBYlLTpQ7hSHsqUQjxahGQAAAAAAACJRICzHnLRuUv8eMl5kh0A8f/4A/mvAcuQknAbt689s+/lqAUATY6If1lUNSH0s2UI6Ti0apPiwlLceyPxuG+5vR7CsAbU0D94LpaP4EfZRfA1GiJACGV8hOF7FkiAHmY3K5FPPAkcwRAIgMYOFoRf6G3cspGadod79DLAuST62P6vtTlH+UvoPzuoCIHDPwcDBeGHrquk74xnGFdvr0OnsD9AjbuYJt1MY9R15ASEDhZS+ZnNs6APXZAkWDkeDvzqKT6lXguuqbLeS+XRWVWQCRzBEAiAIIv2qGd3h6nReZwS6OKG6nybELSxtiyG6AIYTzo8UWgIgL/yRrp1l0saAI0bzFAYW+gVC5VGZzP+Gv3OE3KFa1BoBIQM4guWryygPB3dobSPQTcOW2TS1g8eLb8OzhCC5LSAfIQJHMEQCIEK1DJwZijCfxZsEZO8PxUN3c5ZrVdLXEBNm7ywmoeCZAiBcyrkwimikecB6j1m5DkZG5rJesHNCURDEsc6pkieIWQEhA8qZAOmH/7cNTp8hIRB7a9zbaMqJ1QdKKwi4qh+e1WujAUD3DU+6gX2YtZytOCkNA/6TziVQAlGRS+HhUMphwcQIE38YC3x87QFydYCvKxnm/hC7aP8cT6DDIUlpAcGjiix+AUB74E7YK/XhQJ0PoAROmsMgMOQq+HrYsj6JxAgQbFTWuGaxKNWQFlnkPojlrXPYFU60iKMqLmEq+9CcbdiOqtnZAUAmP488TYNBSsSzJRCrRrLQOHuQff25cJYxV7aepkJZsK/4e5O0Qrcnc2KZLiopritP+6uV4RTAF8yAM0h2lfdGAUC5IHcJuOrk7fxERLgCZdfbu3pLB8lgEmys5b7zm9kntYwqu3w1oec3mm2fcZSnc0x/Z0LHNYH/KXqlCO2k/st6AkcwRAIgH0No1HAMUB8jXSRtqmQLIulbPfplP8emr1rT/rNHV3QCIEj9TZPr6q8cawJtRxgVj8R+T+I5XW3AnmoN+ncHeR4QASEC3aVRvisZGX9+g7aUORFdlqmRTuxYLnct4ErjikvTZCABQGDH4wNdH6eSIFHMh3WV5ZsZ41s7L3g1FfUgeyxSGzC6DeVqamS8hgn+8/Leri1nDZc4OFMefEEsh+UVwehcffsBQPz3qAFwZX2iMVtpFUUl7cyvUGBPNUYKSTK3myxMCOOQ82WLzse0E7Dw09gL/hoAygXONTq8/iOrf9wRjkyJTqkBQJ6fNh31G5qNllj0ekOetxPUhTh1D320zHVAeIetFUeXR8/JY4e1zjoKu/RdGbgt8AuujhOIticqJPcnSXv1mLYBQDw+EpFp7hVG6R7V/is/2PYh7IGbrqoq4yNekRsmhr0h5umdAk1WTUMBwCFBrGnKxHUtDJRgQSVeVH1/NucTR6MBQJLjOecHm/228i8fHlhEVgi+7dAN+W1iaauAzCdLkqHhhytVF6eDqTcwxfeD+8xyI9NNigu5T+DGGv2RZawtxPcBQOw6sSr8BOKrWoQ5KrwObpnkYLgxseuAT7vwqtqPD3ek0V4KdDW8fUxH9a3+6him/iQ+a8TO403bLzSmWZy/VYcBQAYmDZgiZwPT5YcIBw4lclSJHGpz15Ukxnn5zO5ltKj/yGN1imSo5pi9ZU6ZIJjeBInFTxTh24fGd/UOi7IuJYYBQCCP5aqcivrdkkfeOaCw2ZbMqIGF7FWH2RaOZI9wFJDWzkJfzZUNt7V3WeFefDndBKqMoKKEk3nGARy9apfgMBQBQGx70mHzILdGj00tRY7IHePXiGuAC7bW1gmyHVPZdk8t/pFXdmX5R5Zy1pRM5VWrmuhzwLedI+Ec2ppfvRuD9GUBQBUnFV0qhEWfAK196uu0O+M1+BaR0L4/cbxxsWqIr1Ky2885II7KBbN5Lw3btfV8jGyeJS2sXSgJPtejWk9mSCIBQEeTi3XQB+vxTr9ZDo7+sxLV+IrKgSyq969MLg6PJHKckbWtphmdvFqjaEr6D+kLpai6+fWE++b/sEJCwZhFOEMBQByIRbTl6PjsghKhctYYmLKQ8skpSW+VGgnQ+X/zGsWsHplvO0sAvYNLxESn4dt01VaZowgnhfa26FvQ/MumnYUBQOSe14k5R0OtDwuL5CPhRjfAEe0iJH65I4Gr4srqWKdDvgdsiFz7oqn9GaE/GWblZGfXXyepwxZfP67MbhQlAzgBQIpzXe9+DvtjDzzCc9WC1vDLpiV5o0Ycwr+HiH/dSzxK5Ztl7fckvpwl0j2Gh/FQI/8069l+7lzcKUOJaHwN2IABQFp0MBvLAK23XPWof0CaEfi4l88VDxznlkNdE0WVpN2oezc74Ak9KlLTY5DdLreXO1bL76hnWJy9rjvJUhL6GKECRzBEAiA80b2GxJ6bjyI3K44gafQjB6AZHZvVxEfWVLudxIhs3wIgds/fWqfEJdtU+bmehoqhsFRaOGj+GmZgFU+wXbriz1MBIQLSRsD+8ZoD3L1xmJNznK2aWuxOSCaYpP6k1TnH3O7JfAFAp9pJCCRDYObvm1TTihA2SJjv8W4PHqLro82jyLlYkY3datsBj5LciKxYjz+XV7N5LNWVASjn5Zd6XJWMh43WFgFA2TOe4bcW/nzUCboInLh107HZDMvErkvEAz7YsKxUel6Y1oSALh/qFxR8wHaQylibKN5wTGHaKnuf8O9JCjLAxAJHMEQCIHp5W4AfmXKkV9t37qVk5u8Tp2v5C6SQR8YbhkukbtNGAiA9MACl26Kje8U0VleIyZ3gfzcz/FzXwWwOJM3DIybdKgEhA16OuCHbBpk/BGwTlSBFPHbYtlCXG+Ubq4S1tAPAf5EOAUCtWch7PX6R1HB/pe0i+1X7zbyAgH7u34kb/GhtpRcfKJFUR1XSKNAOD0xvVxlxmbMkyK6iTHFVbHmOgiAvdNcUAUDWI+qXknK3UjCSk4BurIEzPJAak3g2cMmwPnyEWy83u3R4fjy+mhAB5vT+xyt1ziwfl+o08se+eAGTaaU7cCy3AUAjT7G+QAenGYowEVuMw6BHwTOHVdenHmozwRqBaM27x/x4mTwSvQZNZctPSei9s6XRnW0I+fX6KeQwRw/jZ23IAAAAAAEHAAEIbAJIMEUCIQDpkRg1Sk1nNl8Ic6P+OhVjRMU1PxXPlmajofd2V+aOlwIgRfncgmow1aK+wSDdzMZasSPZJ5q7JpaoqHblAii1J/0BIQJ4AasN94X6xFQC3n3oefehB+O6QRcO0flg+oQWlONVTgABAR93pgIAAAAAABYAFJY1NwsAE2kp1+6s+g4Tg1NJ42ItAQD9qgEBAAAAAAEC6yIEhr+GiyvnVR/h0j4kD3PeliMi5pT5urtdUgAx4aMAAAAAAP3///9lYyrBY7/rCaDGSDHtotibaMOwmZ7bELqnFlPL0+9m/wEAAAAA/f///wN3pgIAAAAAABYAFJY1NwsAE2kp1+6s+g4Tg1NJ42ItQEIPAAAAAAAiUSCdc8A35E5P03nqDgFlgGWVEvaHYXLNGo1Yzwhdt5Ub7EBCDwAAAAAAIlEgnXPAN+ROT9N56g4BZYBllRL2h2FyzRqNWM8IXbeVG+wCSDBFAiEA6gq2My7/01npqJUBh4KVsPoiCc/Y2QGnNxUehUS/F5ACIBaitVrz+gAYF+zLDo/kd1gtatYIPPs+jUaFBXuqx6btASECu0bdNtz4sexWL4Ei25pqQvJHhg/8TzHBxuJ/PnraChwCRzBEAiBYDJqBBVzMCH/dxbAVx0lHxKlKtkPBwGYICgDo1SCtUAIgTc/mVbUViqgeG6SeKo1h098WPwz7DHVLLxQmM8pz0DUBIQOA4sA7XlIBfcRH/mM9g1gTrSP9Ppo2sy9m47YE9XjD7AAAAAABGZNTTAAZAAHuC2EMXMyDdY6K+X0BubfyUrXHOpo70Eqcl+NPUdgxugACSDBFAiEAjjWWLl6/aFxm8zEjDDhGr8JDOYTZHJKFIWH+SwD3HogCIAFLNtp50qjgtD9QPKP8kVn0yMWOoB7xsDLoNdSGdFpdASEDP32Izo+u0i3ivIqxrIMXH/tTPaPoZSDigvlBf5WoY30AAAAAAA==

[SomberNight]

That looks ok. Well... I don't know. I can't reproduce. :/
It is weird that it errors on step 8. It is step 5 where the ownership proofs are used.
For step 8, somewhat older code that has #8324 should already be sufficient.

[hynek-jina]

I'm able to sign the transaction when I upload the seed directly into Electrum (without Trezor).

[hynek-jina]

It works on Trezor T and Trezor Safe 3, but not on Trezor One

[SomberNight]

It works on Trezor T and Trezor Safe 3, but not on Trezor One

Indeed, I can reproduce. Thanks for investigating. Not sure what is going on, it must be due to legacy/modern trezor fw differences I guess. Let's move this discussion to #8910