Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix $dynamicRef unresolved framed instance locations #1564

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Feb 12, 2025

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: 8b72f38 Previous: 3cb57b5 Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 2.207958349887311 ns/iter 2.187971504792112 ns/iter 1.01
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.1976887878139055 ns/iter 2.18465849390817 ns/iter 1.01
Regex_Period_Asterisk 2.197300599086922 ns/iter 2.1860228271261413 ns/iter 1.01
Regex_Group_Period_Asterisk_Group 2.21366869343757 ns/iter 2.1822111865727813 ns/iter 1.01
Regex_Period_Plus 2.493512110655801 ns/iter 2.4857367176668665 ns/iter 1.00
Regex_Period 2.484980196475389 ns/iter 2.4865374752144658 ns/iter 1.00
Regex_Caret_Period_Plus_Dollar 2.4859748085434727 ns/iter 2.485749551331424 ns/iter 1.00
Regex_Caret_Group_Period_Plus_Group_Dollar 2.485628396523281 ns/iter 2.4858175987271416 ns/iter 1.00
Regex_Caret_Period_Asterisk_Dollar 3.418737458676892 ns/iter 2.1899915602085818 ns/iter 1.56
Regex_Caret_Group_Period_Asterisk_Group_Dollar 3.4190643309117257 ns/iter 2.1832911564104527 ns/iter 1.57
Regex_Caret_X_Hyphen 6.221062876989188 ns/iter 12.625931327271623 ns/iter 0.49
Regex_Period_Md_Dollar 74.42299780955435 ns/iter 75.46704387108726 ns/iter 0.99
Regex_Caret_Slash_Period_Asterisk 7.165066310762397 ns/iter 5.91017975794524 ns/iter 1.21
Regex_Caret_Period_Range_Dollar 4.040318262709832 ns/iter 2.835749843080797 ns/iter 1.42
Regex_Nested_Backtrack 458.2327464767937 ns/iter 454.23252391752186 ns/iter 1.01
JSON_Array_Of_Objects_Unique 403.2756931058042 ns/iter 406.03879904664507 ns/iter 0.99
JSON_Parse_1 30991.122558272233 ns/iter 30308.730230338377 ns/iter 1.02
JSON_Fast_Hash_Helm_Chart_Lock 59.64565619960515 ns/iter 59.69554219251507 ns/iter 1.00
JSON_Equality_Helm_Chart_Lock 147.4840304757339 ns/iter 161.0595081772458 ns/iter 0.92
JSON_String_Equal/10 7.1573294476217555 ns/iter 7.4687538125556285 ns/iter 0.96
JSON_String_Equal/100 6.847795148281795 ns/iter 7.100356948720657 ns/iter 0.96
JSON_String_Equal_Small_By_Perfect_Hash/10 0.9348779492920561 ns/iter 0.9352317816813283 ns/iter 1.00
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 10.256016275991016 ns/iter 10.261991284661717 ns/iter 1.00
JSON_String_Fast_Hash/10 2.184250046941795 ns/iter 2.175190303884711 ns/iter 1.00
JSON_String_Fast_Hash/100 2.1781180214310782 ns/iter 2.1786371621692524 ns/iter 1.00
JSON_String_Key_Hash/10 1.8682593806220558 ns/iter 1.8673320634799766 ns/iter 1.00
JSON_String_Key_Hash/100 2.1796653155948627 ns/iter 2.177621101115697 ns/iter 1.00
JSON_Object_Defines_Miss_Same_Length 3.7333067324095617 ns/iter 3.751163015015236 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Small 3.74161086749095 ns/iter 3.7356843372123025 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Large 3.743232567648715 ns/iter 3.828260611780748 ns/iter 0.98
Pointer_Object_Traverse 44.32235772203423 ns/iter 45.63630343856881 ns/iter 0.97
Pointer_Object_Try_Traverse 52.34436092607871 ns/iter 52.294180864861666 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 286.94775461817846 ns/iter 336.83554918607115 ns/iter 0.85
Schema_Frame_OMC_Instances 224365256.00001764 ns/iter 218142869.66665956 ns/iter 1.03
Schema_Frame_OMC_References 144222055.79999173 ns/iter 141938885.39999762 ns/iter 1.02
Schema_Bundle_Meta_2020_12 6773489.300968825 ns/iter 6795890.823525497 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: 8b72f38 Previous: 3cb57b5 Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 1.5803195303068898 ns/iter 1.7137003365687908 ns/iter 0.92
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 1.5661204457416262 ns/iter 1.6950974602420248 ns/iter 0.92
Regex_Period_Asterisk 1.5662549602905265 ns/iter 2.089712781442645 ns/iter 0.75
Regex_Group_Period_Asterisk_Group 1.5782120203177386 ns/iter 1.920566333349111 ns/iter 0.82
Regex_Period_Plus 1.8962047101256114 ns/iter 2.3801615125399063 ns/iter 0.80
Regex_Period 1.8980567058072912 ns/iter 2.1096025284977227 ns/iter 0.90
Regex_Caret_Period_Plus_Dollar 1.893836136856304 ns/iter 2.178766742057361 ns/iter 0.87
Regex_Caret_Group_Period_Plus_Group_Dollar 1.8978721241962577 ns/iter 2.1595613807798313 ns/iter 0.88
Regex_Caret_Period_Asterisk_Dollar 1.5726152196036465 ns/iter 1.7122570201933038 ns/iter 0.92
Regex_Caret_Group_Period_Asterisk_Group_Dollar 1.567618202290237 ns/iter 1.7514945685349894 ns/iter 0.90
Regex_Caret_X_Hyphen 6.262771250286911 ns/iter 6.937976483884532 ns/iter 0.90
Regex_Period_Md_Dollar 67.912063266038 ns/iter 72.65229236370597 ns/iter 0.93
Regex_Caret_Slash_Period_Asterisk 5.295563050912532 ns/iter 6.958468566276517 ns/iter 0.76
Regex_Caret_Period_Range_Dollar 2.0371402290276923 ns/iter 2.2324496390118087 ns/iter 0.91
Regex_Nested_Backtrack 734.014732594765 ns/iter 793.3203328668662 ns/iter 0.93
JSON_Array_Of_Objects_Unique 327.99615796004264 ns/iter 353.9759713696454 ns/iter 0.93
JSON_Parse_1 22389.35538336251 ns/iter 25315.723822404405 ns/iter 0.88
JSON_Fast_Hash_Helm_Chart_Lock 48.268740681241525 ns/iter 51.80945402150343 ns/iter 0.93
JSON_Equality_Helm_Chart_Lock 119.32469307860663 ns/iter 132.67770752864945 ns/iter 0.90
JSON_String_Equal/10 7.523862485787357 ns/iter 8.314247145660278 ns/iter 0.90
JSON_String_Equal/100 5.96034820426213 ns/iter 6.408686624092193 ns/iter 0.93
JSON_String_Equal_Small_By_Perfect_Hash/10 0.3143282956564018 ns/iter 0.3336086761492006 ns/iter 0.94
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 2.9447013541640046 ns/iter 3.1224772098858016 ns/iter 0.94
JSON_String_Fast_Hash/10 1.567510858457056 ns/iter 1.6839368315547503 ns/iter 0.93
JSON_String_Fast_Hash/100 1.8850119575962092 ns/iter 2.0485056073077317 ns/iter 0.92
JSON_String_Key_Hash/10 1.2768303229649907 ns/iter 1.3798899485444187 ns/iter 0.93
JSON_String_Key_Hash/100 1.2707189345602137 ns/iter 1.3714379321304522 ns/iter 0.93
JSON_Object_Defines_Miss_Same_Length 2.216786462424385 ns/iter 2.4015683216493433 ns/iter 0.92
JSON_Object_Defines_Miss_Too_Small 2.200761767955659 ns/iter 2.478218075702739 ns/iter 0.89
JSON_Object_Defines_Miss_Too_Large 2.1925399688590095 ns/iter 2.4122187238703576 ns/iter 0.91
Pointer_Object_Traverse 15.37552467247102 ns/iter 16.88581977227211 ns/iter 0.91
Pointer_Object_Try_Traverse 21.729520825217328 ns/iter 23.597735408024764 ns/iter 0.92
Pointer_Push_Back_Pointer_To_Weak_Pointer 171.2679794957234 ns/iter 181.9308411156831 ns/iter 0.94
Schema_Frame_OMC_Instances 165881895.75000456 ns/iter 181306395.99999654 ns/iter 0.91
Schema_Frame_OMC_References 94819422.57143925 ns/iter 113091433.19999747 ns/iter 0.84
Schema_Bundle_Meta_2020_12 4386902.251569423 ns/iter 4944777.143839629 ns/iter 0.89

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: 8b72f38 Previous: 3cb57b5 Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 7.008130580355194 ns/iter 6.601735491071586 ns/iter 1.06
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 6.974519165291671 ns/iter 6.6736104910728296 ns/iter 1.05
Regex_Period_Asterisk 6.995852678571676 ns/iter 6.5416919642860965 ns/iter 1.07
Regex_Group_Period_Asterisk_Group 6.909416487012331 ns/iter 6.680691964286366 ns/iter 1.03
Regex_Period_Plus 7.3559866071423325 ns/iter 7.188319196428848 ns/iter 1.02
Regex_Period 7.273064732142842 ns/iter 7.188179687498725 ns/iter 1.01
Regex_Caret_Period_Plus_Dollar 7.086830357142811 ns/iter 6.998306919643633 ns/iter 1.01
Regex_Caret_Group_Period_Plus_Group_Dollar 7.144587053571984 ns/iter 7.214943080356814 ns/iter 0.99
Regex_Caret_Period_Asterisk_Dollar 6.581823214286178 ns/iter 6.614631696427255 ns/iter 1.00
Regex_Caret_Group_Period_Asterisk_Group_Dollar 6.697335937500628 ns/iter 6.717406250000834 ns/iter 1.00
Regex_Caret_X_Hyphen 14.408363105320174 ns/iter 14.371505292984363 ns/iter 1.00
Regex_Period_Md_Dollar 155.44814732143055 ns/iter 155.48832589280843 ns/iter 1.00
Regex_Caret_Slash_Period_Asterisk 10.56446093749841 ns/iter 9.982594642853622 ns/iter 1.06
Regex_Caret_Period_Range_Dollar 7.527498883929593 ns/iter 7.239632812500016 ns/iter 1.04
Regex_Nested_Backtrack 584.1716964285736 ns/iter 586.8394642856092 ns/iter 1.00
JSON_Array_Of_Objects_Unique 415.1700849596368 ns/iter 445.1590740203781 ns/iter 0.93
JSON_Parse_1 79760.0910673602 ns/iter 99375.38502743685 ns/iter 0.80
JSON_Fast_Hash_Helm_Chart_Lock 63.2906250000076 ns/iter 60.8392800000047 ns/iter 1.04
JSON_Equality_Helm_Chart_Lock 191.96198142519088 ns/iter 188.67401166634752 ns/iter 1.02
JSON_String_Equal/10 9.335207101182087 ns/iter 9.441516922136545 ns/iter 0.99
JSON_String_Equal/100 9.959937499999683 ns/iter 10.240145043571266 ns/iter 0.97
JSON_String_Equal_Small_By_Perfect_Hash/10 2.1663565624997716 ns/iter 2.1820921850646453 ns/iter 0.99
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 14.490761160713207 ns/iter 14.45460261403954 ns/iter 1.00
JSON_String_Fast_Hash/10 3.107699553571105 ns/iter 3.1863867237283743 ns/iter 0.98
JSON_String_Fast_Hash/100 3.1117647321425226 ns/iter 3.166902661197989 ns/iter 0.98
JSON_String_Key_Hash/10 7.620725446429841 ns/iter 7.662356026786808 ns/iter 0.99
JSON_String_Key_Hash/100 3.713510886225 ns/iter 3.713712962947541 ns/iter 1.00
JSON_Object_Defines_Miss_Same_Length 4.0293523286238715 ns/iter 4.020733444679435 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Small 3.4135003510476194 ns/iter 3.4116735653356254 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Large 3.720900976328937 ns/iter 3.74100749332053 ns/iter 0.99
Pointer_Object_Traverse 52.54333928570126 ns/iter 52.16636999998627 ns/iter 1.01
Pointer_Object_Try_Traverse 64.71061607141694 ns/iter 64.73561607143503 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 162.51553320418577 ns/iter 158.736941964323 ns/iter 1.02
Schema_Frame_OMC_Instances 483170500.0000284 ns/iter 487845950.0000645 ns/iter 0.99
Schema_Frame_OMC_References 351020500.0000042 ns/iter 350919299.9999868 ns/iter 1.00
Schema_Bundle_Meta_2020_12 16304265.853671873 ns/iter 16521428.888876876 ns/iter 0.99

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/gcc)

Benchmark suite Current: 8b72f38 Previous: 3cb57b5 Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 2.0299013187943 ns/iter 2.165804910368419 ns/iter 0.94
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.0086172490595753 ns/iter 2.0174181989533055 ns/iter 1.00
Regex_Period_Asterisk 2.002999384831827 ns/iter 2.0278345501376913 ns/iter 0.99
Regex_Group_Period_Asterisk_Group 1.9925246387313602 ns/iter 2.045454670119806 ns/iter 0.97
Regex_Period_Plus 1.6536039027933018 ns/iter 1.7160498780371998 ns/iter 0.96
Regex_Period 1.6609769950387856 ns/iter 1.709262163069511 ns/iter 0.97
Regex_Caret_Period_Plus_Dollar 1.6559236031932674 ns/iter 1.711734428829416 ns/iter 0.97
Regex_Caret_Group_Period_Plus_Group_Dollar 1.6527209822502325 ns/iter 1.6956796569241581 ns/iter 0.97
Regex_Caret_Period_Asterisk_Dollar 1.9963473289941966 ns/iter 2.0298772822745845 ns/iter 0.98
Regex_Caret_Group_Period_Asterisk_Group_Dollar 1.9926307462856268 ns/iter 2.187839251257763 ns/iter 0.91
Regex_Caret_X_Hyphen 6.771752533684141 ns/iter 7.1694987020099035 ns/iter 0.94
Regex_Period_Md_Dollar 73.11500112975484 ns/iter 88.68281333715727 ns/iter 0.82
Regex_Caret_Slash_Period_Asterisk 4.693771822776279 ns/iter 6.412689685821533 ns/iter 0.73
Regex_Caret_Period_Range_Dollar 1.9694851536196387 ns/iter 2.055398766218483 ns/iter 0.96
Regex_Nested_Backtrack 846.4541336206883 ns/iter 926.2993933422454 ns/iter 0.91
JSON_Array_Of_Objects_Unique 211.28304186072694 ns/iter 226.25097586387642 ns/iter 0.93
JSON_Parse_1 22839.062692120104 ns/iter 25295.84738964388 ns/iter 0.90
JSON_Fast_Hash_Helm_Chart_Lock 23.46738225974842 ns/iter 25.377855291239207 ns/iter 0.92
JSON_Equality_Helm_Chart_Lock 115.2231111674268 ns/iter 123.73640414815686 ns/iter 0.93
JSON_String_Equal/10 5.595515197353749 ns/iter 5.825241727700581 ns/iter 0.96
JSON_String_Equal/100 5.399778490786519 ns/iter 5.478718635201637 ns/iter 0.99
JSON_String_Equal_Small_By_Perfect_Hash/10 0.7885150879553439 ns/iter 0.8115778037811187 ns/iter 0.97
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 4.090265059700492 ns/iter 3.7497400981241116 ns/iter 1.09
JSON_String_Fast_Hash/10 2.016536639087056 ns/iter 2.064800149623718 ns/iter 0.98
JSON_String_Fast_Hash/100 2.03548261448072 ns/iter 2.2098344612637444 ns/iter 0.92
JSON_String_Key_Hash/10 1.73030080672534 ns/iter 1.5600973193998493 ns/iter 1.11
JSON_String_Key_Hash/100 2.04315375396458 ns/iter 2.085254677451283 ns/iter 0.98
JSON_Object_Defines_Miss_Same_Length 1.837438663894231 ns/iter 1.9252895390126707 ns/iter 0.95
JSON_Object_Defines_Miss_Too_Small 1.999088888111881 ns/iter 2.02973153909992 ns/iter 0.98
JSON_Object_Defines_Miss_Too_Large 1.8226795830462468 ns/iter 1.8825536359378001 ns/iter 0.97
Pointer_Object_Traverse 55.16348985267672 ns/iter 56.38416728441766 ns/iter 0.98
Pointer_Object_Try_Traverse 39.06159437335693 ns/iter 39.60049604768033 ns/iter 0.99
Pointer_Push_Back_Pointer_To_Weak_Pointer 166.85558880952183 ns/iter 172.34776873341403 ns/iter 0.97
Schema_Frame_OMC_Instances 174306511.8789673 ns/iter 183514058.5899353 ns/iter 0.95
Schema_Frame_OMC_References 101342337.47209822 ns/iter 111875136.69331868 ns/iter 0.91
Schema_Bundle_Meta_2020_12 4638213.985013646 ns/iter 5211871.369440753 ns/iter 0.89

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: 8b72f38 Previous: 3cb57b5 Ratio
Schema_Frame_OMC_Instances 221584256.66665003 ns/iter 219508570.00001633 ns/iter 1.01
Schema_Frame_OMC_References 144720444.5999887 ns/iter 143256470.00000572 ns/iter 1.01
Schema_Bundle_Meta_2020_12 7049120.484846827 ns/iter 6945609.504952591 ns/iter 1.01
Pointer_Object_Traverse 48.44064992118427 ns/iter 48.3344958637155 ns/iter 1.00
Pointer_Object_Try_Traverse 24.02152414749878 ns/iter 22.678778860062263 ns/iter 1.06
Pointer_Push_Back_Pointer_To_Weak_Pointer 174.69768313175746 ns/iter 169.89576518089356 ns/iter 1.03
JSON_Array_Of_Objects_Unique 393.10172209770496 ns/iter 378.43572560868165 ns/iter 1.04
JSON_Parse_1 33314.30700710021 ns/iter 33594.79452514226 ns/iter 0.99
JSON_Fast_Hash_Helm_Chart_Lock 64.38119799143331 ns/iter 63.111987850028385 ns/iter 1.02
JSON_Equality_Helm_Chart_Lock 152.01714182371236 ns/iter 155.3882518624976 ns/iter 0.98
JSON_String_Equal/10 5.998716112230626 ns/iter 5.988546205548817 ns/iter 1.00
JSON_String_Equal/100 6.590681945204042 ns/iter 6.610727463803629 ns/iter 1.00
JSON_String_Equal_Small_By_Perfect_Hash/10 0.6234796379326221 ns/iter 0.934928986673093 ns/iter 0.67
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 11.662019319907213 ns/iter 11.812183774070231 ns/iter 0.99
JSON_String_Fast_Hash/10 0.9745036433271942 ns/iter 0.9333560022920905 ns/iter 1.04
JSON_String_Fast_Hash/100 0.9684548726484367 ns/iter 0.9325053559190847 ns/iter 1.04
JSON_String_Key_Hash/10 1.244523205310954 ns/iter 1.2445376856800263 ns/iter 1.00
JSON_String_Key_Hash/100 0.9348574005745077 ns/iter 0.9334453019576209 ns/iter 1.00
JSON_Object_Defines_Miss_Same_Length 2.4977238177264596 ns/iter 2.4880888190271073 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Small 2.567495212256379 ns/iter 2.4875380161819622 ns/iter 1.03
JSON_Object_Defines_Miss_Too_Large 2.8002357882576665 ns/iter 2.487173481404533 ns/iter 1.13
Regex_Lower_S_Or_Upper_S_Asterisk 3.2875884927602756 ns/iter 3.109226513257359 ns/iter 1.06
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.943096121039247 ns/iter 3.1083189037258823 ns/iter 0.95
Regex_Period_Asterisk 2.932209978253349 ns/iter 3.1088526175349505 ns/iter 0.94
Regex_Group_Period_Asterisk_Group 2.9374623474428097 ns/iter 3.1085138605013523 ns/iter 0.94
Regex_Period_Plus 3.1682434859232256 ns/iter 3.417718701134358 ns/iter 0.93
Regex_Period 3.163685697150827 ns/iter 3.4181489713591127 ns/iter 0.93
Regex_Caret_Period_Plus_Dollar 3.156645834862101 ns/iter 3.1090182957869352 ns/iter 1.02
Regex_Caret_Group_Period_Plus_Group_Dollar 3.145231487124375 ns/iter 3.1084888934108825 ns/iter 1.01
Regex_Caret_Period_Asterisk_Dollar 4.0727970882858315 ns/iter 3.4223508238294427 ns/iter 1.19
Regex_Caret_Group_Period_Asterisk_Group_Dollar 4.061374968891067 ns/iter 3.449800040757713 ns/iter 1.18
Regex_Caret_X_Hyphen 13.682864758215622 ns/iter 13.074148192284072 ns/iter 1.05
Regex_Period_Md_Dollar 90.40214751269335 ns/iter 89.68103456568214 ns/iter 1.01
Regex_Caret_Slash_Period_Asterisk 9.044884608115197 ns/iter 9.343383404757741 ns/iter 0.97
Regex_Caret_Period_Range_Dollar 4.076857103741504 ns/iter 3.529747433096597 ns/iter 1.15
Regex_Nested_Backtrack 825.1264045209318 ns/iter 836.4595257135691 ns/iter 0.99

This comment was automatically generated by workflow using github-action-benchmark.

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti changed the title [WIP] Fix $dynamicRef unresolved framed instance locations Fix $dynamicRef unresolved framed instance locations Feb 12, 2025
@jviotti jviotti marked this pull request as ready for review February 12, 2025 17:55
@jviotti jviotti merged commit 40811fd into main Feb 12, 2025
13 checks passed
@jviotti jviotti deleted the frame-dynamic-ref branch February 12, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant