-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup CITATION.cff #212
Setup CITATION.cff #212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I commented the introduced changes to explain their purpose. Please have a look at it and tell me whether further adjustments are required.
The next step is to discuss the actual implementation of the update automation for the CITATION.cff. The update steps are rather straightforward: replacing the old version with the new one and updating the release date to "today". Is there any workflow I can put the two required |
I have just been doing it manually and thinking that I should find a tool to automate it. Rather than adding sed commands let's do that now...? Maybe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 to merge if you feel it's ready.
You can go ahead and merge this PR. I will submit a separate PR for the automatic maintenance (#213). |
The tests are not running because the Docker image for the validation tool is not a trusted Action, yet. How to fix this problem, @sourcefrog? |
Thanks for diagnosing it. I can add it to the allowlist. |
I will close and reopen this PR to have the tests run once again. |
I looked at the Actions docs and I couldn't see how to allow Docker containers. On the whole this doesn't seem like a file that is likely to be edited very often at all (other than version bumps) and so it's not really important to have it automatically validated. So, could you remove that for now and we'll just add the file? |
Yes, no problem. I will remove the test. 👍 |
I just updated the |
This PR adds a basic setup for citation metadata powered by CITATION.cff, as discussed in #210. (Please note that any papers citing this project using these information are yet to be written. 😉)