Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup CITATION.cff #212

Merged
merged 4 commits into from
Jan 14, 2024
Merged

Setup CITATION.cff #212

merged 4 commits into from
Jan 14, 2024

Conversation

kevinmatthes
Copy link
Contributor

This PR adds a basic setup for citation metadata powered by CITATION.cff, as discussed in #210. (Please note that any papers citing this project using these information are yet to be written. 😉)

Copy link
Contributor Author

@kevinmatthes kevinmatthes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented the introduced changes to explain their purpose. Please have a look at it and tell me whether further adjustments are required.

CITATION.cff Outdated Show resolved Hide resolved
.github/workflows/tests.yml Outdated Show resolved Hide resolved
@kevinmatthes
Copy link
Contributor Author

The next step is to discuss the actual implementation of the update automation for the CITATION.cff. The update steps are rather straightforward: replacing the old version with the new one and updating the release date to "today".

Is there any workflow I can put the two required sed commands or do you use cargo-release?

@sourcefrog
Copy link
Owner

The next step is to discuss the actual implementation of the update automation for the CITATION.cff. The update steps are rather straightforward: replacing the old version with the new one and updating the release date to "today".

Is there any workflow I can put the two required sed commands or do you use cargo-release?

I have just been doing it manually and thinking that I should find a tool to automate it. Rather than adding sed commands let's do that now...? Maybe cargo-release is a good choice. It looks like we could configure it to update this file. Filed #213

Copy link
Owner

@sourcefrog sourcefrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 to merge if you feel it's ready.

@kevinmatthes kevinmatthes marked this pull request as ready for review January 2, 2024 19:49
@kevinmatthes
Copy link
Contributor Author

@sourcefrog

You can go ahead and merge this PR. I will submit a separate PR for the automatic maintenance (#213).

@kevinmatthes
Copy link
Contributor Author

The tests are not running because the Docker image for the validation tool is not a trusted Action, yet. How to fix this problem, @sourcefrog?

@sourcefrog
Copy link
Owner

Thanks for diagnosing it. I can add it to the allowlist.

@kevinmatthes
Copy link
Contributor Author

I will close and reopen this PR to have the tests run once again.

@kevinmatthes kevinmatthes reopened this Jan 7, 2024
@sourcefrog
Copy link
Owner

I looked at the Actions docs and I couldn't see how to allow Docker containers.

On the whole this doesn't seem like a file that is likely to be edited very often at all (other than version bumps) and so it's not really important to have it automatically validated. So, could you remove that for now and we'll just add the file?

@kevinmatthes
Copy link
Contributor Author

Yes, no problem. I will remove the test. 👍

@kevinmatthes
Copy link
Contributor Author

I just updated the version and date-released fields to refer to today's release. You can go ahead and merge this PR, I removed the test as you requested.

@sourcefrog sourcefrog merged commit 51cce71 into sourcefrog:main Jan 14, 2024
10 checks passed
@kevinmatthes kevinmatthes deleted the feature/cff branch January 14, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants