Skip to content

Commit

Permalink
Baazar plugins: Fixed api warnings
Browse files Browse the repository at this point in the history
"bazaar" and "baazar-backend" has been removed from the list of
"allowed warnings"."

Signed-off-by: Niklas Aronsson <niklasar@axis.com>
  • Loading branch information
Niklas Aronsson committed Jul 15, 2022
1 parent a3b9b7f commit 77abf50
Show file tree
Hide file tree
Showing 8 changed files with 12 additions and 14 deletions.
6 changes: 6 additions & 0 deletions .changeset/young-seas-report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@backstage/plugin-bazaar': patch
'@backstage/plugin-bazaar-backend': patch
---

Fixed api warnings
4 changes: 0 additions & 4 deletions plugins/bazaar-backend/api-report.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,9 @@ import express from 'express';
import { Logger } from 'winston';
import { PluginDatabaseManager } from '@backstage/backend-common';

// Warning: (ae-missing-release-tag) "createRouter" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export function createRouter(options: RouterOptions): Promise<express.Router>;

// Warning: (ae-missing-release-tag) "RouterOptions" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export interface RouterOptions {
// (undocumented)
Expand Down
2 changes: 2 additions & 0 deletions plugins/bazaar-backend/src/service/router.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,14 @@ import { Logger } from 'winston';
import { Config } from '@backstage/config';
import { DatabaseHandler } from './DatabaseHandler';

/** @public */
export interface RouterOptions {
logger: Logger;
database: PluginDatabaseManager;
config: Config;
}

/** @public */
export async function createRouter(
options: RouterOptions,
): Promise<express.Router> {
Expand Down
8 changes: 0 additions & 8 deletions plugins/bazaar/api-report.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,9 @@
import { BackstagePlugin } from '@backstage/core-plugin-api';
import { RouteRef } from '@backstage/core-plugin-api';

// Warning: (ae-missing-release-tag) "BazaarPage" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export const BazaarPage: () => JSX.Element;

// Warning: (ae-missing-release-tag) "bazaarPlugin" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export const bazaarPlugin: BackstagePlugin<
{
Expand All @@ -23,13 +19,9 @@ export const bazaarPlugin: BackstagePlugin<
{}
>;

// Warning: (ae-missing-release-tag) "EntityBazaarInfoCard" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export const EntityBazaarInfoCard: () => JSX.Element | null;

// Warning: (ae-missing-release-tag) "SortView" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export const SortView: () => JSX.Element;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import { EntityBazaarInfoContent } from '../EntityBazaarInfoContent';
import { Card } from '@material-ui/core';
import { parseBazaarResponse } from '../../util/parseMethods';

/** @public */
export const EntityBazaarInfoCard = () => {
const { entity } = useEntity();
const bazaarApi = useApi(bazaarApiRef);
Expand Down
1 change: 1 addition & 0 deletions plugins/bazaar/src/components/SortView/SortView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ const getUnlinkedCatalogEntities = (
});
};

/** @public */
export const SortView = () => {
const bazaarApi = useApi(bazaarApiRef);
const catalogApi = useApi(catalogApiRef);
Expand Down
2 changes: 2 additions & 0 deletions plugins/bazaar/src/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import {
} from '@backstage/core-plugin-api';
import { bazaarApiRef, BazaarClient } from './api';

/** @public */
export const bazaarPlugin = createPlugin({
id: 'bazaar',
routes: {
Expand All @@ -44,6 +45,7 @@ export const bazaarPlugin = createPlugin({
],
});

/** @public */
export const BazaarPage = bazaarPlugin.provide(
createRoutableExtension({
name: 'BazaarPage',
Expand Down
2 changes: 0 additions & 2 deletions scripts/api-extractor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,6 @@ const ALLOW_WARNINGS = [
'plugins/azure-devops-common',
'plugins/badges',
'plugins/badges-backend',
'plugins/bazaar',
'plugins/bazaar-backend',
'plugins/bitrise',
'plugins/catalog',
'plugins/catalog-graphql',
Expand Down

0 comments on commit 77abf50

Please sign in to comment.